linux-kernel - Re: [PATCH v3 28/34] misc: Intel tsens IA host driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 29 Jan 2021 23:01:30 -0800
From:   Joe Perches <joe@...ches.com>
To:     mgross@...ux.intel.com, markgross@...nel.org, arnd@...db.de,
        bp@...e.de, damien.lemoal@....com, dragan.cvetic@...inx.com,
        gregkh@...uxfoundation.org, corbet@....net,
        palmerdabbelt@...gle.com, paul.walmsley@...ive.com,
        peng.fan@....com, robh+dt@...nel.org, shawnguo@...nel.org,
        jassisinghbrar@...il.com
Cc:     linux-kernel@...r.kernel.org,
        "C, Udhayakumar" <udhayakumar.c@...el.com>, C@...ux.intel.com
Subject: Re: [PATCH v3 28/34] misc: Intel tsens IA host driver.

On Fri, 2021-01-29 at 18:20 -0800, mgross@...ux.intel.com wrote:
> From: "C, Udhayakumar" <udhayakumar.c@...el.com>
> 
> Add Intel tsens IA host driver for Intel Edge.AI Computer Vision
> platforms.
[]
> diff --git a/drivers/misc/intel_tsens/intel_tsens_host.c b/drivers/misc/intel_tsens/intel_tsens_host.c
[]
> +static int tsens_i2c_smbus_read_byte_data(struct i2c_client *i2c, u8 command,
> +					  u8 *i2c_val)
> +{
> +	union i2c_smbus_data data;
> +	int status;
> +
> +	status = i2c_smbus_xfer(i2c->adapter, i2c->addr, i2c->flags,
> +				I2C_SMBUS_READ, command,
> +				I2C_SMBUS_BYTE_DATA, &data);

this can fail

> +	*i2c_val = data.byte;

Is it appropriate to set the value if it failed and data was
not initialized?

> +	return status;
> +}
> +
> +/**
> + * intel_tsens_get_temp - get updated temperatue

Might want to use codespell on all files.