linux-kernel - Re: [PATCH v2 4/4] arm64: dts: qcom: msm8916-alcatel-idol347: Add framebuffer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Jan 2021 16:42:37 +0100
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Vincent Knecht <vincent.knecht@...loo.org>,
        phone-devel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht,
        Rob Herring <robh+dt@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Shawn Guo <shawnguo@...nel.org>,
        Daniel Palmer <daniel@...f.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        allen <allen.chen@....com.tw>,
        Max Merchel <Max.Merchel@...group.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: msm8916-alcatel-idol347: Add
 framebuffer support


On 30.01.2021 11:57, Vincent Knecht wrote:
> Add simple-framebuffer support and related reserved-memory block.
>
> Signed-off-by: Vincent Knecht <vincent.knecht@...loo.org>
> ---
>  .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> index 540b1fa4b260..e4d22cec8ff0 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
> @@ -3,6 +3,7 @@
>  /dts-v1/;
>  
>  #include "msm8916-pm8916.dtsi"
> +#include <dt-bindings/clock/qcom,gcc-msm8916.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
>  
> @@ -16,6 +17,36 @@ aliases {
>  
>  	chosen {
>  		stdout-path = "serial0";
> +
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		framebuffer0: framebuffer@...00000 {
> +			status = "okay";
> +			compatible = "simple-framebuffer";
> +			reg = <0x0 0x83200000 0x0 (720 * 1280 * 3)>;
> +			width = <720>;
> +			height = <1280>;
> +			stride = <(720 * 3)>;
> +			format = "r8g8b8";
> +			power-domains = <&gcc MDSS_GDSC>;
> +			clocks = <&gcc GCC_MDSS_AHB_CLK>,
> +				 <&gcc GCC_MDSS_VSYNC_CLK>,
> +				 <&gcc GCC_MDSS_AXI_CLK>,
> +				 <&gcc GCC_MDSS_MDP_CLK>,
> +				 <&gcc GCC_MDSS_BYTE0_CLK>,
> +				 <&gcc GCC_MDSS_PCLK0_CLK>,

I'm not sure about BYTE/PCLK, it used to cause issues at least on my boards, but if it works for you, I guess it's only good.


> +				 <&gcc GCC_MDSS_ESC0_CLK>,
> +				 <&xo_board>;

Fake XO seems redundant here.


> +		};
> +	};
> +
> +	reserved-memory {
> +		continuous_splash: framebuffer@...00000 {
> +			reg = <0x0 0x83000000 0x0 0x1400000>;
> +			no-map;
> +		};
>  	};
>  
>  	gpio-keys {
>

Konrad