linux-kernel - Re: [PATCH v4 26/34] dt-bindings: misc: intel_tsens: Add tsens thermal bindings documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1612027420.847882.1419429.nullmailer@robh.at.kernel.org>
Date:   Sat, 30 Jan 2021 11:23:40 -0600
From:   Rob Herring <robh@...nel.org>
To:     mgross@...ux.intel.com
Cc:     jassisinghbrar@...il.com,
        "C, Udhayakumar" <udhayakumar.c@...el.com>, corbet@....net,
        dragan.cvetic@...inx.com, palmerdabbelt@...gle.com,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        damien.lemoal@....com, shawnguo@...nel.org,
        paul.walmsley@...ive.com, arnd@...db.de, robh+dt@...nel.org,
        peng.fan@....com, bp@...e.de, markgross@...nel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v4 26/34] dt-bindings: misc: intel_tsens: Add tsens thermal bindings documentation

On Fri, 29 Jan 2021 18:21:16 -0800, mgross@...ux.intel.com wrote:
> From: "C, Udhayakumar" <udhayakumar.c@...el.com>
> 
> Add device tree bindings for local host thermal sensors
> Intel Edge.AI Computer Vision platforms.
> 
> The tsens module enables reading of on chip sensors present
> in the Intel Bay series SoC. In the tsens module various junction
> temperature and SoC temperature are reported using thermal subsystem
> and i2c subsystem.
> 
> Temperature data reported using thermal subsystem will be used for
> various cooling agents such as DVFS, fan control and shutdown the
> system in case of critical temperature.
> 
> Temperature data reported using i2c subsytem will be used by
> platform manageability software running in remote host.
> 
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: devicetree@...r.kernel.org
> Acked-by: mark gross <mgross@...ux.intel.com>
> Signed-off-by: C Udhayakumar <udhayakumar.c@...el.com>
> Signed-off-by: Mark Gross <mgross@...ux.intel.com>
> ---
>  .../bindings/misc/intel,intel-tsens.yaml      | 118 ++++++++++++++++++
>  1 file changed, 118 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/intel,intel-tsens.example.dt.yaml: example-0: tsens@...60000:reg:0: [0, 539361280, 0, 256] is too long
	From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/reg.yaml

See https://patchwork.ozlabs.org/patch/1433609

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.