| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 30 Jan 2021 10:34:54 -0800
From: Kyung Min Park <kyung.min.park@...el.com>
To: Lu Baolu <baolu.lu@...ux.intel.com>, linux-kernel@...r.kernel.org,
iommu@...ts.linux-foundation.org
Cc: dwmw2@...radead.org, joro@...tes.org, will@...nel.org,
ricardo.neri@...el.com, ravi.v.shankar@...el.com,
kevin.tian@...el.com, ashok.raj@...el.com, sohil.mehta@...el.com
Subject: Re: [PATCH v4 1/3] iommu/vt-d: Audit IOMMU Capabilities and add
helper functions
Hi Allen,
On Tue, 2021-01-19 at 09:55 +0800, Lu Baolu wrote:
> Hi,
>
> On 1/6/21 9:30 AM, Kyung Min Park wrote:
> > Audit IOMMU Capability/Extended Capability and check if the IOMMUs
> > have
> > the consistent value for features. Report out or scale to the
> > lowest
> > supported when IOMMU features have incompatibility among IOMMUs.
> >
> > Report out features when below features are mismatched:
> > - First Level 5 Level Paging Support (FL5LP)
> > - First Level 1 GByte Page Support (FL1GP)
> > - Read Draining (DRD)
> > - Write Draining (DWD)
> > - Page Selective Invalidation (PSI)
> > - Zero Length Read (ZLR)
> > - Caching Mode (CM)
> > - Protected High/Low-Memory Region (PHMR/PLMR)
> > - Required Write-Buffer Flushing (RWBF)
> > - Advanced Fault Logging (AFL)
> > - RID-PASID Support (RPS)
> > - Scalable Mode Page Walk Coherency (SMPWC)
> > - First Level Translation Support (FLTS)
> > - Second Level Translation Support (SLTS)
> > - No Write Flag Support (NWFS)
> > - Second Level Accessed/Dirty Support (SLADS)
> > - Virtual Command Support (VCS)
> > - Scalable Mode Translation Support (SMTS)
> > - Device TLB Invalidation Throttle (DIT)
> > - Page Drain Support (PDS)
> > - Process Address Space ID Support (PASID)
> > - Extended Accessed Flag Support (EAFS)
> > - Supervisor Request Support (SRS)
> > - Execute Request Support (ERS)
> > - Page Request Support (PRS)
> > - Nested Translation Support (NEST)
> > - Snoop Control (SC)
> > - Pass Through (PT)
> > - Device TLB Support (DT)
> > - Queued Invalidation (QI)
> > - Page walk Coherency (C)
> >
> > Set capability to the lowest supported when below features are
> > mismatched:
> > - Maximum Address Mask Value (MAMV)
> > - Number of Fault Recording Registers (NFR)
> > - Second Level Large Page Support (SLLPS)
> > - Fault Recording Offset (FRO)
> > - Maximum Guest Address Width (MGAW)
> > - Supported Adjusted Guest Address Width (SAGAW)
> > - Number of Domains supported (NDOMS)
> > - Pasid Size Supported (PSS)
> > - Maximum Handle Mask Value (MHMV)
> > - IOTLB Register Offset (IRO)
> >
> > Signed-off-by: Kyung Min Park <kyung.min.park@...el.com>
> > ---
> > drivers/iommu/intel/Makefile | 4 +-
> > drivers/iommu/intel/cap_audit.c | 188
> > ++++++++++++++++++++++++++++
> > drivers/iommu/intel/cap_audit.h | 106 ++++++++++++++++
> > drivers/iommu/intel/iommu.c | 9 ++
> > drivers/iommu/intel/irq_remapping.c | 8 ++
> > include/linux/intel-iommu.h | 39 +++---
> > 6 files changed, 334 insertions(+), 20 deletions(-)
> > create mode 100644 drivers/iommu/intel/cap_audit.c
> > create mode 100644 drivers/iommu/intel/cap_audit.h
> >
> > diff --git a/drivers/iommu/intel/Makefile
> > b/drivers/iommu/intel/Makefile
> > index fb8e1e8c8029..1e576c840175 100644
> > --- a/drivers/iommu/intel/Makefile
> > +++ b/drivers/iommu/intel/Makefile
> > @@ -1,7 +1,7 @@
> > # SPDX-License-Identifier: GPL-2.0
> > obj-$(CONFIG_DMAR_TABLE) += dmar.o
> > obj-$(CONFIG_INTEL_IOMMU) += iommu.o pasid.o
> > -obj-$(CONFIG_INTEL_IOMMU) += trace.o
> > +obj-$(CONFIG_INTEL_IOMMU) += trace.o cap_audit.o
> > obj-$(CONFIG_INTEL_IOMMU_DEBUGFS) += debugfs.o
> > obj-$(CONFIG_INTEL_IOMMU_SVM) += svm.o
> > -obj-$(CONFIG_IRQ_REMAP) += irq_remapping.o
> > +obj-$(CONFIG_IRQ_REMAP) += irq_remapping.o cap_audit.o
> > diff --git a/drivers/iommu/intel/cap_audit.c
> > b/drivers/iommu/intel/cap_audit.c
> > new file mode 100644
> > index 000000000000..4a062fc719d2
> > --- /dev/null
> > +++ b/drivers/iommu/intel/cap_audit.c
> > @@ -0,0 +1,188 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * cap_audit.c - audit iommu capabilities for boot time and hot
> > plug
> > + *
> > + * Copyright (C) 2020 Intel Corporation
>
> Update to 2021. The same to other places.
Sure. Let me make changes. :)
>
> > + *
> > + * Author: Kyung Min Park <kyung.min.park@...el.com>
> > + * Lu Baolu <baolu.lu@...ux.intel.com>
> > + */
> > +
> > +#define pr_fmt(fmt) "DMAR: " fmt
> > +
> > +#include <linux/intel-iommu.h>
> > +#include "cap_audit.h"
> > +
> > +static u64 intel_iommu_cap_sanity;
> > +static u64 intel_iommu_ecap_sanity;
> > +
> > +static inline void check_irq_capabilities(struct intel_iommu *a,
> > + struct intel_iommu *b)
> > +{
> > + CHECK_FEATURE_MISMATCH(a, b, cap, pi_support, CAP_PI_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, eim_support, ECAP_EIM_MASK);
> > +}
> > +
> > +static inline void check_dmar_capabilities(struct intel_iommu *a,
> > + struct intel_iommu *b)
> > +{
> > + MINIMAL_FEATURE_IOMMU(b, cap, CAP_MAMV_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, cap, CAP_NFR_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, cap, CAP_SLLPS_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, cap, CAP_FRO_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, cap, CAP_MGAW_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, cap, CAP_SAGAW_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, cap, CAP_NDOMS_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, ecap, ECAP_PSS_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, ecap, ECAP_MHMV_MASK);
> > + MINIMAL_FEATURE_IOMMU(b, ecap, ECAP_IRO_MASK);
> > +
> > + CHECK_FEATURE_MISMATCH(a, b, cap, 5lp_support, CAP_FL5LP_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, fl1gp_support,
> > CAP_FL1GP_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, read_drain, CAP_RD_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, write_drain, CAP_WD_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, pgsel_inv, CAP_PSI_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, zlr, CAP_ZLR_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, caching_mode, CAP_CM_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, phmr, CAP_PHMR_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, plmr, CAP_PLMR_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, rwbf, CAP_RWBF_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, cap, afl, CAP_AFL_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, rps, ECAP_RPS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, smpwc, ECAP_SMPWC_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, flts, ECAP_FLTS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, slts, ECAP_SLTS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, nwfs, ECAP_NWFS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, slads, ECAP_SLADS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, vcs, ECAP_VCS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, smts, ECAP_SMTS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, pds, ECAP_PDS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, dit, ECAP_DIT_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, pasid, ECAP_PASID_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, eafs, ECAP_EAFS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, srs, ECAP_SRS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, ers, ECAP_ERS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, prs, ECAP_PRS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, nest, ECAP_NEST_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, mts, ECAP_MTS_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, sc_support, ECAP_SC_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, pass_through, ECAP_PT_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, dev_iotlb_support,
> > ECAP_DT_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, qis, ECAP_QI_MASK);
> > + CHECK_FEATURE_MISMATCH(a, b, ecap, coherent, ECAP_C_MASK);
> > +}
> > +
> > +static int cap_audit_hotplug(struct intel_iommu *iommu, enum
> > cap_audit_type type)
> > +{
> > + bool mismatch = false;
> > + u64 old_cap = intel_iommu_cap_sanity;
> > + u64 old_ecap = intel_iommu_ecap_sanity;
> > +
> > + if (type == CAP_AUDIT_HOTPLUG_IRQR) {
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, pi_support,
> > CAP_PI_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap,
> > eim_support, ECAP_EIM_MASK);
> > + goto out;
> > + }
> > +
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, 5lp_support,
> > CAP_FL5LP_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, fl1gp_support,
> > CAP_FL1GP_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, read_drain,
> > CAP_RD_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, write_drain,
> > CAP_WD_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, pgsel_inv,
> > CAP_PSI_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, zlr, CAP_ZLR_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, caching_mode,
> > CAP_CM_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, phmr,
> > CAP_PHMR_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, plmr,
> > CAP_PLMR_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, rwbf,
> > CAP_RWBF_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, cap, afl, CAP_AFL_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, rps,
> > ECAP_RPS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, smpwc,
> > ECAP_SMPWC_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, flts,
> > ECAP_FLTS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, slts,
> > ECAP_SLTS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, nwfs,
> > ECAP_NWFS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, slads,
> > ECAP_SLADS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, vcs,
> > ECAP_VCS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, smts,
> > ECAP_SMTS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, pds,
> > ECAP_PDS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, dit,
> > ECAP_DIT_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, pasid,
> > ECAP_PASID_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, eafs,
> > ECAP_EAFS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, srs,
> > ECAP_SRS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, ers,
> > ECAP_ERS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, prs,
> > ECAP_PRS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, nest,
> > ECAP_NEST_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, mts,
> > ECAP_MTS_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, sc_support,
> > ECAP_SC_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, pass_through,
> > ECAP_PT_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, dev_iotlb_support,
> > ECAP_DT_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, qis, ECAP_QI_MASK);
> > + CHECK_FEATURE_MISMATCH_HOTPLUG(iommu, ecap, coherent,
> > ECAP_C_MASK);
> > +
> > + /* Abort hot plug if the hot plug iommu feature is smaller than
> > global */
> > + MINIMAL_FEATURE_HOTPLUG(iommu, cap, max_amask_val,
> > CAP_MAMV_MASK, mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, cap, num_fault_regs,
> > CAP_NFR_MASK, mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, cap, super_page_val,
> > CAP_SLLPS_MASK, mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, cap, fault_reg_offset,
> > CAP_FRO_MASK, mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, cap, mgaw, CAP_MGAW_MASK,
> > mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, cap, sagaw, CAP_SAGAW_MASK,
> > mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, cap, ndoms, CAP_NDOMS_MASK,
> > mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, ecap, pss, ECAP_PSS_MASK,
> > mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, ecap, max_handle_mask,
> > ECAP_MHMV_MASK, mismatch);
> > + MINIMAL_FEATURE_HOTPLUG(iommu, ecap, iotlb_offset,
> > ECAP_IRO_MASK, mismatch);
> > +
> > +out:
> > + if (mismatch) {
> > + intel_iommu_cap_sanity = old_cap;
> > + intel_iommu_ecap_sanity = old_ecap;
> > + return -EFAULT;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static int cap_audit_static(struct intel_iommu *iommu, enum
> > cap_audit_type type)
> > +{
> > + struct dmar_drhd_unit *d;
> > + struct intel_iommu *i;
> > +
> > + rcu_read_lock();
> > + if (list_empty(&dmar_drhd_units))
> > + goto out;
> > +
> > + for_each_active_iommu(i, d) {
> > + /* do not audit capabilities for gfx dedicated iommu */
>
> Please add a comment about the reason why do you want to skip gfx
> iommu.
> What if the users passthrough the gfx device together with other
> devices
> to user level but the underlying iommu's might have different
> capabilities or capacities?
As we discussed offline, we need to work more on the gfx and SVM
coherency policies. So, I'll drop the SVM coherency policy in this
patchset. Thank you for your feedback!
>
> > + if (d->gfx_dedicated) {
> > + continue;
> > + } else if (!iommu) {
>
> "else" is not needed. Just "if (!iommu)".
Sure, I'll fix in the next patch.
>
> > + intel_iommu_ecap_sanity = i->ecap;
> > + intel_iommu_cap_sanity = i->cap;
> > + iommu = i;
> > + continue;
> > + }
> > +
> > + if (type == CAP_AUDIT_STATIC_DMAR)
> > + check_dmar_capabilities(iommu, i);
> > + else
> > + check_irq_capabilities(iommu, i);
> > + }
> > +
> > +out:
> > + rcu_read_unlock();
> > + return 0;
> > +}
> > +
> > +int intel_cap_audit(enum cap_audit_type type, struct intel_iommu
> > *iommu)
> > +{
> > + switch (type) {
> > + case CAP_AUDIT_STATIC_DMAR:
> > + case CAP_AUDIT_STATIC_IRQR:
> > + return cap_audit_static(iommu, type);
> > + case CAP_AUDIT_HOTPLUG_DMAR:
> > + case CAP_AUDIT_HOTPLUG_IRQR:
> > + return cap_audit_hotplug(iommu, type);
> > + default:
> > + break;
> > + }
> > +
> > + return -EFAULT;
> > +}
> > diff --git a/drivers/iommu/intel/cap_audit.h
> > b/drivers/iommu/intel/cap_audit.h
> > new file mode 100644
> > index 000000000000..866236581dd3
> > --- /dev/null
> > +++ b/drivers/iommu/intel/cap_audit.h
> > @@ -0,0 +1,106 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * audit.h - audit iommu capabilities header
> > + *
> > + * Copyright (C) 2020 Intel Corporation
> > + *
> > + * Author: Kyung Min Park <kyung.min.park@...el.com>
> > + */
> > +
> > +/*
> > + * Capability Register Mask
> > + */
> > +#define CAP_FL5LP_MASK BIT_ULL(60)
> > +#define CAP_PI_MASK BIT_ULL(59)
> > +#define CAP_FL1GP_MASK BIT_ULL(56)
> > +#define CAP_RD_MASK BIT_ULL(55)
> > +#define CAP_WD_MASK BIT_ULL(54)
> > +#define CAP_MAMV_MASK GENMASK_ULL(53, 48)
> > +#define CAP_NFR_MASK GENMASK_ULL(47, 40)
> > +#define CAP_PSI_MASK BIT_ULL(39)
> > +#define CAP_SLLPS_MASK GENMASK_ULL(37, 34)
> > +#define CAP_FRO_MASK GENMASK_ULL(33, 24)
> > +#define CAP_ZLR_MASK BIT_ULL(22)
> > +#define CAP_MGAW_MASK GENMASK_ULL(21, 16)
> > +#define CAP_SAGAW_MASK GENMASK_ULL(12, 8)
> > +#define CAP_CM_MASK BIT_ULL(7)
> > +#define CAP_PHMR_MASK BIT_ULL(6)
> > +#define CAP_PLMR_MASK BIT_ULL(5)
> > +#define CAP_RWBF_MASK BIT_ULL(4)
> > +#define CAP_AFL_MASK BIT_ULL(3)
> > +#define CAP_NDOMS_MASK GENMASK_ULL(2, 0)
> > +
> > +/*
> > + * Extended Capability Register Mask
> > + */
> > +#define ECAP_RPS_MASK BIT_ULL(49)
> > +#define ECAP_SMPWC_MASK BIT_ULL(48)
> > +#define ECAP_FLTS_MASK BIT_ULL(47)
> > +#define ECAP_SLTS_MASK BIT_ULL(46)
> > +#define ECAP_SLADS_MASK BIT_ULL(45)
> > +#define ECAP_VCS_MASK BIT_ULL(44)
> > +#define ECAP_SMTS_MASK BIT_ULL(43)
> > +#define ECAP_PDS_MASK BIT_ULL(42)
> > +#define ECAP_DIT_MASK BIT_ULL(41)
> > +#define ECAP_PASID_MASK BIT_ULL(40)
> > +#define ECAP_PSS_MASK GENMASK_ULL(39, 35)
> > +#define ECAP_EAFS_MASK BIT_ULL(34)
> > +#define ECAP_NWFS_MASK BIT_ULL(33)
> > +#define ECAP_SRS_MASK BIT_ULL(31)
> > +#define ECAP_ERS_MASK BIT_ULL(30)
> > +#define ECAP_PRS_MASK BIT_ULL(29)
> > +#define ECAP_NEST_MASK BIT_ULL(26)
> > +#define ECAP_MTS_MASK BIT_ULL(25)
> > +#define ECAP_MHMV_MASK GENMASK_ULL(23, 20)
> > +#define ECAP_IRO_MASK GENMASK_ULL(17, 8)
> > +#define ECAP_SC_MASK BIT_ULL(7)
> > +#define ECAP_PT_MASK BIT_ULL(6)
> > +#define ECAP_EIM_MASK BIT_ULL(4)
> > +#define ECAP_DT_MASK BIT_ULL(2)
> > +#define ECAP_QI_MASK BIT_ULL(1)
> > +#define ECAP_C_MASK BIT_ULL(0)
> > +
> > +#define DO_CHECK_FEATURE_MISMATCH(a, b, cap, feature, MASK) \
> > +do { \
> > + if (cap##_##feature(a) != cap##_##feature(b)) { \
> > + intel_iommu_##cap##_sanity &= ~(MASK); \
> > + pr_info("IOMMU feature %s inconsistent", #feature); \
> > + } \
> > +} while (0)
> > +
> > +#define CHECK_FEATURE_MISMATCH(a, b, cap, feature, MASK) \
> > + DO_CHECK_FEATURE_MISMATCH((a)->cap, (b)->cap, cap, feature,
> > MASK)
> > +
> > +#define CHECK_FEATURE_MISMATCH_HOTPLUG(b, cap, feature, MASK) \
> > +do { \
> > + if (cap##_##feature(intel_iommu_##cap##_sanity)) \
> > + DO_CHECK_FEATURE_MISMATCH(intel_iommu_##cap##_sanity, \
> > + (b)->cap, cap, feature,
> > MASK); \
> > +} while (0)
> > +
> > +#define MINIMAL_FEATURE_IOMMU(iommu, cap, MASK) \
> > +do { \
> > + u64 min_feature = intel_iommu_##cap##_sanity & MASK; \
>
> (MASK)
Sure.
>
> > + min_feature = min_t(u64, min_feature, (iommu)->cap & (MASK)); \
> > + intel_iommu_##cap##_sanity = (intel_iommu_##cap##_sanity &
> > ~(MASK)) | \
> > + min_feature; \
>
> Let the users know that this capacity value has been adjusted.
Sure, I'll make a note.
>
> > +} while (0)
> > +
> > +#define MINIMAL_FEATURE_HOTPLUG(iommu, cap, feature, MASK,
> > mismatch) \
> > +do { \
> > + if ((intel_iommu_##cap##_sanity & (MASK)) > \
> > + (cap##_##feature((iommu)->cap))) \
> > + mismatch = true; \
> > + else \
> > + (iommu)->cap = ((iommu)->cap & ~(MASK)) | \
> > + (intel_iommu_##cap##_sanity & (MASK)); \
> > +} while (0)
> > +
> > +enum cap_audit_type {
> > + CAP_AUDIT_STATIC_DMAR,
> > + CAP_AUDIT_STATIC_IRQR,
> > + CAP_AUDIT_HOTPLUG_DMAR,
> > + CAP_AUDIT_HOTPLUG_IRQR,
> > +};
> > +
> > +int intel_cap_audit(enum cap_audit_type type, struct intel_iommu
> > *iommu);
> > diff --git a/drivers/iommu/intel/iommu.c
> > b/drivers/iommu/intel/iommu.c
> > index a49afa11673c..dd8f41a5e4fa 100644
> > --- a/drivers/iommu/intel/iommu.c
> > +++ b/drivers/iommu/intel/iommu.c
> > @@ -49,6 +49,7 @@
> >
> > #include "../irq_remapping.h"
> > #include "pasid.h"
> > +#include "cap_audit.h"
> >
> > #define ROOT_SIZE VTD_PAGE_SIZE
> > #define CONTEXT_SIZE VTD_PAGE_SIZE
> > @@ -3268,6 +3269,10 @@ static int __init init_dmars(void)
> > goto error;
> > }
> >
> > + ret = intel_cap_audit(CAP_AUDIT_STATIC_DMAR, NULL);
> > + if (ret)
> > + goto free_iommu;
> > +
> > for_each_iommu(iommu, drhd) {
> > if (drhd->ignored) {
> > iommu_disable_translation(iommu);
> > @@ -4407,6 +4412,10 @@ static int intel_iommu_add(struct
> > dmar_drhd_unit *dmaru)
> > if (g_iommus[iommu->seq_id])
> > return 0;
> >
> > + ret = intel_cap_audit(CAP_AUDIT_HOTPLUG_DMAR, iommu);
> > + if (ret)
> > + goto out;
> > +
> > if (hw_pass_through && !ecap_pass_through(iommu->ecap)) {
> > pr_warn("%s: Doesn't support hardware pass through.\n",
> > iommu->name);
> > diff --git a/drivers/iommu/intel/irq_remapping.c
> > b/drivers/iommu/intel/irq_remapping.c
> > index 0cfce1d3b7bb..1094184bd845 100644
> > --- a/drivers/iommu/intel/irq_remapping.c
> > +++ b/drivers/iommu/intel/irq_remapping.c
> > @@ -23,6 +23,7 @@
> > #include <asm/msidef.h>
> >
> > #include "../irq_remapping.h"
> > +#include "cap_audit.h"
> >
> > enum irq_mode {
> > IRQ_REMAPPING,
> > @@ -742,6 +743,9 @@ static int __init
> > intel_prepare_irq_remapping(void)
> > if (dmar_table_init() < 0)
> > return -ENODEV;
> >
> > + if (intel_cap_audit(CAP_AUDIT_STATIC_IRQR, NULL))
> > + goto error;
> > +
> > if (!dmar_ir_support())
> > return -ENODEV;
> >
> > @@ -1459,6 +1463,10 @@ static int dmar_ir_add(struct dmar_drhd_unit
> > *dmaru, struct intel_iommu *iommu)
> > int ret;
> > int eim = x2apic_enabled();
> >
> > + ret = intel_cap_audit(CAP_AUDIT_HOTPLUG_IRQR, iommu);
> > + if (ret)
> > + return ret;
> > +
> > if (eim && !ecap_eim_support(iommu->ecap)) {
> > pr_info("DRHD %Lx: EIM not supported by DRHD, ecap
> > %Lx\n",
> > iommu->reg_phys, iommu->ecap);
> > diff --git a/include/linux/intel-iommu.h b/include/linux/intel-
> > iommu.h
> > index d956987ed032..0d1933dd8b1d 100644
> > --- a/include/linux/intel-iommu.h
> > +++ b/include/linux/intel-iommu.h
> > @@ -168,34 +168,37 @@
> > * Extended Capability Register
> > */
> >
> > +#define ecap_rps(e) (((e) >> 49) & 0x1)
> > #define ecap_smpwc(e) (((e) >> 48) & 0x1)
> > #define ecap_flts(e) (((e) >> 47) & 0x1)
> > #define ecap_slts(e) (((e) >> 46) & 0x1)
> > +#define ecap_slads(e) (((e) >> 45) & 0x1)
> > #define ecap_vcs(e) (((e) >> 44) & 0x1)
> > #define ecap_smts(e) (((e) >> 43) & 0x1)
> > -#define ecap_dit(e) ((e >> 41) & 0x1)
> > -#define ecap_pasid(e) ((e >> 40) & 0x1)
> > -#define ecap_pss(e) ((e >> 35) & 0x1f)
> > -#define ecap_eafs(e) ((e >> 34) & 0x1)
> > -#define ecap_nwfs(e) ((e >> 33) & 0x1)
> > -#define ecap_srs(e) ((e >> 31) & 0x1)
> > -#define ecap_ers(e) ((e >> 30) & 0x1)
> > -#define ecap_prs(e) ((e >> 29) & 0x1)
> > -#define ecap_broken_pasid(e) ((e >> 28) & 0x1)
> > -#define ecap_dis(e) ((e >> 27) & 0x1)
> > -#define ecap_nest(e) ((e >> 26) & 0x1)
> > -#define ecap_mts(e) ((e >> 25) & 0x1)
> > -#define ecap_ecs(e) ((e >> 24) & 0x1)
> > +#define ecap_dit(e) (((e) >> 41) & 0x1)
> > +#define ecap_pds(e) (((e) >> 42) & 0x1)
> > +#define ecap_pasid(e) (((e) >> 40) & 0x1)
> > +#define ecap_pss(e) (((e) >> 35) & 0x1f)
> > +#define ecap_eafs(e) (((e) >> 34) & 0x1)
> > +#define ecap_nwfs(e) (((e) >> 33) & 0x1)
> > +#define ecap_srs(e) (((e) >> 31) & 0x1)
> > +#define ecap_ers(e) (((e) >> 30) & 0x1)
> > +#define ecap_prs(e) (((e) >> 29) & 0x1)
> > +#define ecap_broken_pasid(e) (((e) >> 28) & 0x1)
> > +#define ecap_dis(e) (((e) >> 27) & 0x1)
> > +#define ecap_nest(e) (((e) >> 26) & 0x1)
> > +#define ecap_mts(e) (((e) >> 25) & 0x1)
> > +#define ecap_ecs(e) (((e) >> 24) & 0x1)
> > #define ecap_iotlb_offset(e) ((((e) >> 8) & 0x3ff) * 16)
> > #define ecap_max_iotlb_offset(e) (ecap_iotlb_offset(e) + 16)
> > #define ecap_coherent(e) ((e) & 0x1)
> > #define ecap_qis(e) ((e) & 0x2)
> > -#define ecap_pass_through(e) ((e >> 6) & 0x1)
> > -#define ecap_eim_support(e) ((e >> 4) & 0x1)
> > -#define ecap_ir_support(e) ((e >> 3) & 0x1)
> > +#define ecap_pass_through(e) (((e) >> 6) & 0x1)
> > +#define ecap_eim_support(e) (((e) >> 4) & 0x1)
> > +#define ecap_ir_support(e) (((e) >> 3) & 0x1)
> > #define ecap_dev_iotlb_support(e) (((e) >> 2) & 0x1)
> > -#define ecap_max_handle_mask(e) ((e >> 20) & 0xf)
> > -#define ecap_sc_support(e) ((e >> 7) & 0x1) /* Snooping Control */
> > +#define ecap_max_handle_mask(e) (((e) >> 20) & 0xf)
> > +#define ecap_sc_support(e) (((e) >> 7) & 0x1) /* Snooping Control
> > */
> >
> > /* Virtual command interface capability */
> > #define vccap_pasid(v) (((v) & DMA_VCS_PAS)) /* PASID
> > allocation */
> >
>
> Other look good to me. Thanks for your patch.
>
> Best regards,
> baolu
Powered by blists - more mailing lists