linux-kernel - Re: [PATCH 04/29] sparc: Avoid comma separated statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <537f6b211185eec4e511bc146d1863f448e7d6c7.camel@perches.com>
Date:   Sat, 30 Jan 2021 10:56:17 -0800
From:   Joe Perches <joe@...ches.com>
To:     Jiri Kosina <trivial@...nel.org>, linux-kernel@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>, sparclinux@...r.kernel.org
Subject: Re: [PATCH 04/29] sparc: Avoid comma separated statements

On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> Use semicolons and braces.

ping?

> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  arch/sparc/kernel/smp_64.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel/smp_64.c
> index e286e2badc8a..28c11f7871cd 100644
> --- a/arch/sparc/kernel/smp_64.c
> +++ b/arch/sparc/kernel/smp_64.c
> @@ -186,8 +186,11 @@ static inline long get_delta (long *rt, long *master)
>  		wmb();
>  		t1 = tick_ops->get_tick();
>  
> 
> -		if (t1 - t0 < best_t1 - best_t0)
> -			best_t0 = t0, best_t1 = t1, best_tm = tm;
> +		if (t1 - t0 < best_t1 - best_t0) {
> +			best_t0 = t0;
> +			best_t1 = t1;
> +			best_tm = tm;
> +		}
>  	}
>  
> 
>  	*rt = best_t1 - best_t0;