lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 Jan 2021 09:22:31 +0100
From:   Jan Henrik Weinstock <jan.weinstock@...h-aachen.de>
To:     Stafford Horne <shorne@...il.com>
CC:     <geert@...ux-m68k.org>, <jonas@...thpole.se>,
        <stefan.kristiansson@...nalahti.fi>,
        <openrisc@...ts.librecores.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] openrisc: use device tree to determine present cpus

On 31/01/2021 00:03, Stafford Horne wrote:

> This looks good, one small comment below.  Can you send the next patch as a v2?
> 
> Using 'git format-patch -v2 ...'

Sorry, was not aware of that, will do better next time!

> Should we warn on the else case?

I think it is fine for the kernel to have room for more CPUs than are 
actually present (i.e. NR_CPUs > present_cpus is OK). Other Archs do not 
show a warning in this case either, therefore I also omitted it.

Gruss
Jan


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5316 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ