linux-kernel - Re: [PATCH 1/3] MIPS: ftrace: Fix N32 save registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b1a5eae4-2032-4ace-aa48-a21893e47528@www.fastmail.com>
Date:   Sun, 31 Jan 2021 18:38:01 +0800
From:   "Jiaxun Yang" <jiaxun.yang@...goat.com>
To:     "Jinyang He" <hejinyang@...ngson.cn>,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        "Steven Rostedt" <rostedt@...dmis.org>,
        "Ingo Molnar" <mingo@...hat.com>
Cc:     "Wu Zhangjin" <wuzhangjin@...il.com>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        "Huacai Chen" <chenhuacai@...nel.org>,
        "Tiezhu Yang" <yangtiezhu@...ngson.cn>
Subject: Re: [PATCH 1/3] MIPS: ftrace: Fix N32 save registers



On Sun, Jan 31, 2021, at 4:14 PM, Jinyang He wrote:
> CONFIG_64BIT is confusing. N32 also pass parameters by a0~a7.

Do we have NEW kernel build?
CONFIG_64BIT assumed N64 as kernel ABI.


-Jiaxun

> 
> Signed-off-by: Jinyang He <hejinyang@...ngson.cn>
> ---
>  arch/mips/kernel/mcount.S | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/kernel/mcount.S b/arch/mips/kernel/mcount.S
> index cff52b2..808257a 100644
> --- a/arch/mips/kernel/mcount.S
> +++ b/arch/mips/kernel/mcount.S
> @@ -27,7 +27,7 @@
>  	PTR_S	a1, PT_R5(sp)
>  	PTR_S	a2, PT_R6(sp)
>  	PTR_S	a3, PT_R7(sp)
> -#ifdef CONFIG_64BIT
> +#if _MIPS_SIM == _MIPS_SIM_ABI64 || _MIPS_SIM == _MIPS_SIM_NABI32
>  	PTR_S	a4, PT_R8(sp)
>  	PTR_S	a5, PT_R9(sp)
>  	PTR_S	a6, PT_R10(sp)
> @@ -42,7 +42,7 @@
>  	PTR_L	a1, PT_R5(sp)
>  	PTR_L	a2, PT_R6(sp)
>  	PTR_L	a3, PT_R7(sp)
> -#ifdef CONFIG_64BIT
> +#if _MIPS_SIM == _MIPS_SIM_ABI64 || _MIPS_SIM == _MIPS_SIM_NABI32
>  	PTR_L	a4, PT_R8(sp)
>  	PTR_L	a5, PT_R9(sp)
>  	PTR_L	a6, PT_R10(sp)
> -- 
> 2.1.0
> 
>

-- 
- Jiaxun