linux-kernel - Re: [RFC][PATCH 03/13] mm/vmscan: replace implicit RECLAIM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ea95a1a-33b0-eb15-98d8-79c81dc8a37@google.com>
Date:   Sat, 30 Jan 2021 17:10:37 -0800 (PST)
From:   David Rientjes <rientjes@...gle.com>
To:     Dave Hansen <dave.hansen@...ux.intel.com>
cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        ben.widawsky@...el.com, cl@...ux.com, alex.shi@...ux.alibaba.com,
        tobin@...nel.org, akpm@...ux-foundation.org, ying.huang@...el.com,
        dan.j.williams@...el.com, cai@....pw, dwagner@...e.de,
        osalvador@...e.de
Subject: Re: [RFC][PATCH 03/13] mm/vmscan: replace implicit RECLAIM_ZONE
 checks with explicit checks

On Mon, 25 Jan 2021, Dave Hansen wrote:

> 
> From: Dave Hansen <dave.hansen@...ux.intel.com>
> 
> RECLAIM_ZONE was assumed to be unused because it was never explicitly
> used in the kernel.  However, there were a number of places where it
> was checked implicitly by checking 'node_reclaim_mode' for a zero
> value.
> 
> These zero checks are not great because it is not obvious what a zero
> mode *means* in the code.  Replace them with a helper which makes it
> more obvious: node_reclaim_enabled().
> 
> This helper also provides a handy place to explicitly check the
> RECLAIM_ZONE bit itself.  Check it explicitly there to make it more
> obvious where the bit can affect behavior.
> 
> This should have no functional impact.
> 
> Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
> Reviewed-by: Ben Widawsky <ben.widawsky@...el.com>
> Acked-by: Christoph Lameter <cl@...ux.com>
> Cc: Alex Shi <alex.shi@...ux.alibaba.com>
> Cc: "Tobin C. Harding" <tobin@...nel.org>
> Cc: Christoph Lameter <cl@...ux.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Huang Ying <ying.huang@...el.com>
> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Qian Cai <cai@....pw>
> Cc: Daniel Wagner <dwagner@...e.de>
> Cc: osalvador <osalvador@...e.de>

Acked-by: David Rientjes <rientjes@...gle.com>