linux-kernel - Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 31 Jan 2021 19:54:10 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Hariprasad Kelam <hkelam@...vell.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        David Miller <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Linu Cherian <lcherian@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Jerin Jacob <jerinj@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
Subject: Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration

On Sun, Jan 31, 2021 at 8:11 AM Hariprasad Kelam <hkelam@...vell.com> wrote:
>
> This series of patches add support for forward error correction(fec) and
> physical link configuration. Patches 1&2 adds necessary mbox handlers for fec
> mode configuration request and to fetch stats. Patch 3 registers driver
> callbacks for fec mode configuration and display. Patch 4&5 adds support of mbox
> handlers for configuring link parameters like speed/duplex and autoneg etc.
> Patche 6&7 registers driver callbacks for physical link configuration.
>
> Change-log:
> v2:
>         - Fixed review comments
>         - Corrected indentation issues
>         - Return -ENOMEM incase of mbox allocation failure
>         - added validation for input fecparams bitmask values
>         - added more comments
>
> V3:
>         - Removed inline functions
>         - Make use of ethtool helpers APIs to display supported
>           advertised modes
>         - corrected indentation issues
>         - code changes such that return early in case of failure
>           to aid branch prediction

This addresses my comments to the previous patch series, thanks.

It seems that patchwork only picked up only patch 6/7 unfortunately:
https://patchwork.kernel.org/project/netdevbpf/list/?series=424969

>
> Christina Jacob (6):
>   octeontx2-af: forward error correction configuration
>   octeontx2-pf: ethtool fec mode support
>   octeontx2-af: Physical link configuration support
>   octeontx2-af: advertised link modes support on cgx
>   octeontx2-pf: ethtool physical link status
>   octeontx2-pf: ethtool physical link configuration
>
> Felix Manlunas (1):
>   octeontx2-af: Add new CGX_CMD to get PHY FEC statistics
>
>  drivers/net/ethernet/marvell/octeontx2/af/cgx.c    | 258 ++++++++++++-
>  drivers/net/ethernet/marvell/octeontx2/af/cgx.h    |  10 +
>  .../net/ethernet/marvell/octeontx2/af/cgx_fw_if.h  |  70 +++-
>  drivers/net/ethernet/marvell/octeontx2/af/mbox.h   |  87 ++++-
>  drivers/net/ethernet/marvell/octeontx2/af/rvu.h    |   4 +
>  .../net/ethernet/marvell/octeontx2/af/rvu_cgx.c    |  80 +++++
>  .../ethernet/marvell/octeontx2/nic/otx2_common.c   |  20 ++
>  .../ethernet/marvell/octeontx2/nic/otx2_common.h   |   6 +
>  .../ethernet/marvell/octeontx2/nic/otx2_ethtool.c  | 399 ++++++++++++++++++++-
>  .../net/ethernet/marvell/octeontx2/nic/otx2_pf.c   |   3 +
>  10 files changed, 930 insertions(+), 7 deletions(-)
>
> --
> 2.7.4