linux-kernel - Re: [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Feb 2021 11:41:41 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git <git@...inx.com>,
        Andre Przywara <andre.przywara@....com>,
        devicetree@...r.kernel.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: zynq: Add address-cells property to interrupt controllers

On Mon, Feb 1, 2021 at 8:27 AM Michal Simek <michal.simek@...inx.com> wrote:
>
> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version
> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC
> commit
> "81e0919a3e21 checks: Add interrupt provider test"
> where reasons for this checking are mentioned as
> "A missing #address-cells property is less critical, but creates
> ambiguities when used in interrupt-map properties, so warn about this as
> well now."
>
> Add address-cells property to gic and gpio nodes to get rid of this warning.
> The similar change has been done for ZynqMP too.

FYI, we're going to make this check dependent on having an
interrupt-map property. So adding these isn't necessary.

>
> CC: Andre Przywara <andre.przywara@....com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index df9ad831cf05..c4810d58540b 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -133,6 +133,7 @@ can1: can@...09000 {
>
>                 gpio0: gpio@...0a000 {
>                         compatible = "xlnx,zynq-gpio-1.0";
> +                       #address-cells = <0>;
>                         #gpio-cells = <2>;
>                         clocks = <&clkc 42>;
>                         gpio-controller;
> @@ -168,6 +169,7 @@ i2c1: i2c@...05000 {
>                 intc: interrupt-controller@...01000 {
>                         compatible = "arm,cortex-a9-gic";
>                         #interrupt-cells = <3>;
> +                       #address-cells = <0>;
>                         interrupt-controller;
>                         reg = <0xF8F01000 0x1000>,
>                               <0xF8F00100 0x100>;
> --
> 2.30.0
>