linux-kernel - Re: [PATCH] mwifiex: Report connected BSS with cfg80211_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+ASDXO-bVXhEJE+7kSe85e8i31kzACHeypt-8vBD2ZO2_1=3Q@mail.gmail.com>
Date:   Mon, 1 Feb 2021 14:03:26 -0800
From:   Brian Norris <briannorris@...omium.org>
To:     Yen-lin Lai <yenlinlai@...omium.org>
Cc:     linux-wireless <linux-wireless@...r.kernel.org>,
        Amitkumar Karwar <amitkarwar@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Ganapathi Bhat <ganapathi.bhat@....com>,
        Jakub Kicinski <kuba@...nel.org>,
        Kalle Valo <kvalo@...eaurora.org>,
        Xinming Hu <huxinming820@...il.com>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        "<netdev@...r.kernel.org>" <netdev@...r.kernel.org>
Subject: Re: [PATCH] mwifiex: Report connected BSS with cfg80211_connect_bss()

On Sun, Jan 31, 2021 at 11:07 PM Yen-lin Lai <yenlinlai@...omium.org> wrote:
> When a network is moved or reconfigured on the different channel, there
> can be multiple BSSes with the same BSSID and SSID in scan result
> before the old one expires. Then, it can cause cfg80211_connect_result
> to map current_bss to a bss with the wrong channel.
>
> Let mwifiex_cfg80211_assoc return the selected BSS and then the caller
> can report it cfg80211_connect_bss.
>
> Signed-off-by: Yen-lin Lai <yenlinlai@...omium.org>

This seems sane to me:

Reviewed-by: Brian Norris <briannorris@...omium.org>