linux-kernel - Re: [PATCH v3 3/9] mm/hugetlb: Move flush_hugetlb_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0df405c-a8d6-d4c8-02ba-13a6b0c2ba85@oracle.com>
Date:   Mon, 1 Feb 2021 14:09:24 -0800
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Axel Rasmussen <axelrasmussen@...gle.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anshuman Khandual <anshuman.khandual@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Chinwen Chang <chinwen.chang@...iatek.com>,
        Huang Ying <ying.huang@...el.com>,
        Ingo Molnar <mingo@...hat.com>, Jann Horn <jannh@...gle.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Lokesh Gidra <lokeshgidra@...gle.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Michal Koutný <mkoutny@...e.com>,
        Michel Lespinasse <walken@...gle.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Nicholas Piggin <npiggin@...il.com>,
        Peter Xu <peterx@...hat.com>, Shaohua Li <shli@...com>,
        Shawn Anastasio <shawn@...stas.io>,
        Steven Rostedt <rostedt@...dmis.org>,
        Steven Price <steven.price@....com>,
        Vlastimil Babka <vbabka@...e.cz>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        linux-mm@...ck.org, Adam Ruprecht <ruprecht@...gle.com>,
        Cannon Matthews <cannonmatthews@...gle.com>,
        "Dr . David Alan Gilbert" <dgilbert@...hat.com>,
        David Rientjes <rientjes@...gle.com>,
        Oliver Upton <oupton@...gle.com>
Subject: Re: [PATCH v3 3/9] mm/hugetlb: Move flush_hugetlb_tlb_range() into
 hugetlb.h

On 1/28/21 2:48 PM, Axel Rasmussen wrote:
> From: Peter Xu <peterx@...hat.com>
> 
> Prepare for it to be called outside of mm/hugetlb.c.
> 
> Signed-off-by: Peter Xu <peterx@...hat.com>
> Signed-off-by: Axel Rasmussen <axelrasmussen@...gle.com>
> ---
>  include/linux/hugetlb.h | 8 ++++++++
>  mm/hugetlb.c            | 8 --------
>  2 files changed, 8 insertions(+), 8 deletions(-)

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

-- 
Mike Kravetz

> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 4508136c8376..f94a35296618 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -962,4 +962,12 @@ static inline bool want_pmd_share(struct vm_area_struct *vma)
>  #endif
>  }
>  
> +#ifndef __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE
> +/*
> + * ARCHes with special requirements for evicting HUGETLB backing TLB entries can
> + * implement this.
> + */
> +#define flush_hugetlb_tlb_range(vma, addr, end)	flush_tlb_range(vma, addr, end)
> +#endif
> +
>  #endif /* _LINUX_HUGETLB_H */
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index d46f50a99ff1..30a087dda57d 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -4924,14 +4924,6 @@ long follow_hugetlb_page(struct mm_struct *mm, struct vm_area_struct *vma,
>  	return i ? i : err;
>  }
>  
> -#ifndef __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE
> -/*
> - * ARCHes with special requirements for evicting HUGETLB backing TLB entries can
> - * implement this.
> - */
> -#define flush_hugetlb_tlb_range(vma, addr, end)	flush_tlb_range(vma, addr, end)
> -#endif
> -
>  unsigned long hugetlb_change_protection(struct vm_area_struct *vma,
>  		unsigned long address, unsigned long end, pgprot_t newprot)
>  {
>