linux-kernel - Re: [PATCH] misc: bcm-vk: unlock on error in bcm_to_h_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f4f98962-5c0e-c32a-6e12-ae3b830b19c1@broadcom.com>
Date:   Mon, 1 Feb 2021 14:49:42 -0800
From:   Scott Branden <scott.branden@...adcom.com>
To:     Desmond Yan <desmond.yan@...adcom.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Olof Johansson <olof@...om.net>,
        bcm-kernel-feedback-list@...adcom.com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] misc: bcm-vk: unlock on error in bcm_to_h_msg_dequeue()

Great, looks good then.

On 2021-02-01 10:32 a.m., Desmond Yan wrote:
> Acked-by: Desmond Yan <desmond.yan@...adcom.com>
Acked-by: Scott Branden <scott.branden@...adcom.com>
>
> On Mon, Feb 1, 2021 at 4:24 AM Dan Carpenter <dan.carpenter@...cle.com> wrote:
>> Unlock before returning on this error path.
>>
>> Fixes: 111d746bb476 ("misc: bcm-vk: add VK messaging support")
>> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>> ---
>>  drivers/misc/bcm-vk/bcm_vk_msg.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/bcm-vk/bcm_vk_msg.c b/drivers/misc/bcm-vk/bcm_vk_msg.c
>> index eec90494777d..fc972e43258a 100644
>> --- a/drivers/misc/bcm-vk/bcm_vk_msg.c
>> +++ b/drivers/misc/bcm-vk/bcm_vk_msg.c
>> @@ -849,7 +849,8 @@ s32 bcm_to_h_msg_dequeue(struct bcm_vk *vk)
>>                                  * that is fatal.
>>                                  */
>>                                 dev_crit(dev, "Kernel mem allocation failure.\n");
>> -                               return -ENOMEM;
>> +                               total = -ENOMEM;
>> +                               goto idx_err;
>>                         }
>>
>>                         /* flush rd pointer after a message is dequeued */
>> --
>> 2.29.2
>>