linux-kernel - Re: [RFC 13/20] mm/tlb: introduce tlb_start_ptes() and tlb_end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9D234926-25BF-4456-8EC5-1A578232EF07@vmware.com>
Date:   Mon, 1 Feb 2021 23:00:00 +0000
From:   Nadav Amit <namit@...are.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     Linux-MM <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...nel.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Will Deacon <will@...nel.org>, Yu Zhao <yuzhao@...gle.com>,
        Nick Piggin <npiggin@...il.com>,
        "x86@...nel.org" <x86@...nel.org>
Subject: Re: [RFC 13/20] mm/tlb: introduce tlb_start_ptes() and tlb_end_ptes()

> On Feb 1, 2021, at 5:19 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> 
> On Sat, Jan 30, 2021 at 04:11:25PM -0800, Nadav Amit wrote:
>> +#define tlb_start_ptes(tlb)						\
>> +	do {								\
>> +		struct mmu_gather *_tlb = (tlb);			\
>> +									\
>> +		flush_tlb_batched_pending(_tlb->mm);			\
>> +	} while (0)
>> +
>> +static inline void tlb_end_ptes(struct mmu_gather *tlb) { }
> 
>> 	tlb_change_page_size(tlb, PAGE_SIZE);
>> 	orig_pte = pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl);
>> -	flush_tlb_batched_pending(mm);
>> +	tlb_start_ptes(tlb);
>> 	arch_enter_lazy_mmu_mode();
>> 	for (; addr < end; pte++, addr += PAGE_SIZE) {
>> 		ptent = *pte;
>> @@ -468,6 +468,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
>> 	}
>> 
>> 	arch_leave_lazy_mmu_mode();
>> +	tlb_end_ptes(tlb);
>> 	pte_unmap_unlock(orig_pte, ptl);
>> 	if (pageout)
>> 		reclaim_pages(&page_list);
> 
> I don't like how you're dubbling up on arch_*_lazy_mmu_mode(). It seems
> to me those should be folded into tlb_{start,end}_ptes().
> 
> Alternatively, the even more work approach would be to, add an optional
> @tlb argument to pte_offset_map_lock()/pte_unmap_unlock() and friends.

Not too fund of the “even more approach”. I still have debts I need to
pay to the kernel community on old patches that didn’t make it through.

I will fold arch_*_lazy_mmu_mode() as you suggested. Admittedly, I do not
understand this arch_*_lazy_mmu_mode() very well - I would have assumed
they would be needed only when PTEs are established, and in other cases
the arch code will hook directly to the TLB flushing interface.

However, based on the code, it seems that powerpc does not even flush PTEs
that are established (only removed/demoted). Probably I am missing
something. I will just blindly fold it.