linux-kernel - Re: [PATCH] serial: 8250: add option to disable registration of legacy ISA ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YBewA7FDXSjR6kIq@kroah.com>
Date:   Mon, 1 Feb 2021 08:38:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Mans Rullgard <mans@...sr.com>, Jiri Slaby <jirislaby@...nel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] serial: 8250: add option to disable registration of
 legacy ISA ports

On Sun, Jan 31, 2021 at 09:25:33PM +0200, Andy Shevchenko wrote:
> On Thursday, January 28, 2021, Mans Rullgard <mans@...sr.com> wrote:
> 
> > On systems that do not have the traditional PC ISA serial ports, the
> > 8250 driver still creates non-functional device nodes.  This change
> > makes only ports that actually exist (PCI, DT, ...) get device nodes.
> >
> >
> 
> This is kinda ABI breakage. At least this will break x86 platforms with
> HSUARTs (all modern ones) that are used in embedded systems.
> 
> I think you would rather need an option to disable this and select it by
> the platforms where it is known not to break anything.

This option is behind CONFIG_EXPERT, if you set it, you know what you
are doing, so that's fine.

thanks,

greg k-h