linux-kernel - Re: [PATCH v3] misc: bcm-vk: only support ttyVK if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBexqH9KZEMs2fq0@kroah.com>
Date:   Mon, 1 Feb 2021 08:45:44 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Scott Branden <scott.branden@...adcom.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Kees Cook <keescook@...omium.org>,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com,
        Olof Johansson <olof@...om.net>,
        Desmond Yan <desmond.yan@...adcom.com>
Subject: Re: [PATCH v3] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set

On Sun, Jan 31, 2021 at 03:30:49PM -0800, Scott Branden wrote:
> Correct compile issue if CONFIG_TTY is not set by
> only adding ttyVK devices if CONFIG_BCM_VK_TTY is set.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Scott Branden <scott.branden@...adcom.com>
> 
> ---
> Changes since v2:
> - add CONFIG_BCM_VK_TTY
> - add function and stub for bcm_vk_tty_set_irq_enabled
> Changes since v1:
> - add function stubs rather than compiling out code
> ---
>  drivers/misc/bcm-vk/Kconfig      | 16 ++++++++++++
>  drivers/misc/bcm-vk/Makefile     |  4 +--
>  drivers/misc/bcm-vk/bcm_vk.h     | 42 +++++++++++++++++++++++++++++---
>  drivers/misc/bcm-vk/bcm_vk_dev.c |  5 ++--
>  drivers/misc/bcm-vk/bcm_vk_tty.c |  6 +++++
>  5 files changed, 65 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig
> index 052f6f28b540..16ce98c964b8 100644
> --- a/drivers/misc/bcm-vk/Kconfig
> +++ b/drivers/misc/bcm-vk/Kconfig
> @@ -15,3 +15,19 @@ config BCM_VK
>  	  accelerators via /dev/bcm-vk.N devices.
>  
>  	  If unsure, say N.
> +
> +if BCM_VK

No need for this, just put it on the depends line, right?

> +
> +config BCM_VK_TTY
> +	bool "Enable ttyVK"

Better config help text to explain what this is?


> +	depends on TTY
> +	default y

Default y is only there if your system can not boot without it, please
remove it.

> +	help
> +	  Select this option to enable ttyVK support to allow console
> +	  access to VK cards from host.

Again, more help text, what is a "VK"?

thanks,

greg k-h