linux-kernel - Re: turbostat: Fix Pkg Power on Zen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c7074c16-5d64-e829-10f6-ef91f5f6222b@garloff.de>
Date:   Mon, 1 Feb 2021 10:01:31 +0100
From:   Kurt Garloff <kurt@...loff.de>
To:     Len Brown <len.brown@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: turbostat: Fix Pkg Power on Zen

Hi Len,

Issue persists on Ryzen in 5.11-rc6:

kvmadmin@...tSrv2018(//):~ [0]$ sudo /casa/src/linux-stable/tools/power/x86/turbostat/turbostat
turbostat version 20.09.30 - Len Brown <lenb@...nel.org>
CPUID(0): AuthenticAMD 0x10 CPUID levels; 0x80000023 xlevels; family:model:stepping 0x19:21:0 (25:33:0)
CPUID(1): SSE3 MONITOR - - - TSC MSR - HT -
CPUID(6): APERF, No-TURBO, No-DTS, No-PTM, No-HWP, No-HWPnotify, No-HWPwindow, No-HWPepp, No-HWPpkg, No-EPB
CPUID(7): No-SGX
RAPL: 234 sec. Joule Counter Range, at 280 Watts
/dev/cpu_dma_latency: 2000000000 usec (default)
current_driver: acpi_idle
current_governor: menu
current_governor_ro: menu
cpu22: POLL: CPUIDLE CORE POLL IDLE
cpu22: C1: ACPI FFH MWAIT 0x0
cpu22: C2: ACPI IOPORT 0x414
cpu22: cpufreq driver: acpi-cpufreq
cpu22: cpufreq governor: schedutil
cpufreq boost: 1
cpu0: MSR_RAPL_PWR_UNIT: 0x000a1003 (0.125000 Watts, 0.000015 Joules, 0.000977 sec.)
kvmadmin@...tSrv2018(//):~ [243]$

                            ^^^ Exit code

With the patch:

kvmadmin@...tSrv2018(//):~ [243]$ sudo /casa/src/linux-stable/tools/power/x86/turbostat/turbostat   
turbostat version 20.09.30 - Len Brown <lenb@...nel.org>                                                                               
CPUID(0): AuthenticAMD 0x10 CPUID levels; 0x80000023 xlevels; family:model:stepping 0x19:21:0 (25:33:0)
CPUID(1): SSE3 MONITOR - - - TSC MSR - HT -                                                                                            
CPUID(6): APERF, No-TURBO, No-DTS, No-PTM, No-HWP, No-HWPnotify, No-HWPwindow, No-HWPepp, No-HWPpkg, No-EPB         
CPUID(7): No-SGX                                                                                                                       
RAPL: 234 sec. Joule Counter Range, at 280 Watts                                                                                       
/dev/cpu_dma_latency: 2000000000 usec (default)                                                                                        
current_driver: acpi_idle                                                                                                              
current_governor: menu                                                                                                                 
current_governor_ro: menu                                                                                                              
cpu28: POLL: CPUIDLE CORE POLL IDLE                                                                                                    
cpu28: C1: ACPI FFH MWAIT 0x0                                                                                                          
cpu28: C2: ACPI IOPORT 0x414                                                                                                           
cpu28: cpufreq driver: acpi-cpufreq                                                                                                    
cpu28: cpufreq governor: schedutil                                                                                                     
cpufreq boost: 1                                                                                                                       
cpu0: MSR_RAPL_PWR_UNIT: 0x000a1003 (0.125000 Watts, 0.000015 Joules, 0.000977 sec.)                       
Core    CPU     Avg_MHz Busy%   Bzy_MHz TSC_MHz IRQ     POLL    C1      C2      POLL%   C1%     C2%     CorWatt PkgWatt
-       -       27      1.04    2562    3411    16046   33      2931    12895   0.00    0.85    98.48   1.57    18.81
0       0       12      0.55    2193    3400    885     1       111     757     0.00    1.12    98.42   0.04    18.74
0       16      1       0.05    2351    3400    53      0       3       54      0.00    0.05    99.92      
1       1       20      0.89    2261    3400    478     0       39      427     0.00    0.37    98.80   0.06
1       17      9       0.40    2329    3400    308     0       38      282     0.00    0.35    99.29      
[...]

-- 
Kurt Garloff <kurt@...loff.de>
Cologne, Germany

On 26/12/2020 13:13, Kurt Garloff wrote:
> Hi Len,
>
> find attached fix to avoid exiting with -13 on Zen. Patch is against turbostat as included in Linux-5.10.2.
> Please merge.
>
> PS: This is probably material for -stable, as it used to work before on Zen (Zen2 aka Ryzen 3000 in my case).
>