linux-kernel - Re: [External] [PATCH] misc: pvpanic: sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3369537d-27a9-2a48-9a46-f241a5077dc2@bytedance.com>
Date:   Mon, 1 Feb 2021 09:56:57 +0800
From:   zhenwei pi <pizhenwei@...edance.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [External] [PATCH] misc: pvpanic: sysfs_emit uses should have a
 newline

On 1/30/21 3:08 AM, Joe Perches wrote:
> Add newline terminations to the sysfs_emit uses added by -next
> commit 8d6da6575ffe ("misc: pvpanic: introduce events device attribue")
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>   drivers/misc/pvpanic.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
> index b1e4922a7fda..9f350e05ef68 100644
> --- a/drivers/misc/pvpanic.c
> +++ b/drivers/misc/pvpanic.c
> @@ -25,13 +25,13 @@ static unsigned int events;
>   static ssize_t capability_show(struct device *dev,
>   			       struct device_attribute *attr, char *buf)
>   {
> -	return sysfs_emit(buf, "%x", capability);
> +	return sysfs_emit(buf, "%x\n", capability);
>   }
>   static DEVICE_ATTR_RO(capability);
>   
>   static ssize_t events_show(struct device *dev,  struct device_attribute *attr, char *buf)
>   {
> -	return sysfs_emit(buf, "%x", events);
> +	return sysfs_emit(buf, "%x\n", events);
>   }
>   
>   static ssize_t events_store(struct device *dev,  struct device_attribute *attr,
> 
> 

Hi, Greg is the maintainer of this driver.

-- 
zhenwei pi