linux-kernel - Re: [PATCH] init: clean up early_param_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YBfJeQC1jUeD2fdp@hovoldconsulting.com>
Date:   Mon, 1 Feb 2021 10:27:21 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Joe Perches <joe@...ches.com>, Miguel Ojeda <ojeda@...nel.org>,
        Nick Desaulniers <ndesaulniers@...ogle.com>
Subject: Re: [PATCH] init: clean up early_param_on_off() macro

On Mon, Feb 01, 2021 at 01:15:32PM +0900, Masahiro Yamada wrote:
> Use early_param() to define early_param_on_off().
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> ---
> 
>  include/linux/init.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/init.h b/include/linux/init.h
> index e668832ef66a..ae2c2aace0d0 100644
> --- a/include/linux/init.h
> +++ b/include/linux/init.h
> @@ -277,14 +277,14 @@ struct obs_kernel_param {
>  		var = 1;						\
>  		return 0;						\
>  	}								\
> -	__setup_param(str_on, parse_##var##_on, parse_##var##_on, 1);	\
> +	early_param(str_on, parse_##var##_on);				\
>  									\
>  	static int __init parse_##var##_off(char *arg)			\
>  	{								\
>  		var = 0;						\
>  		return 0;						\
>  	}								\
> -	__setup_param(str_off, parse_##var##_off, parse_##var##_off, 1)
> +	early_param(str_off, parse_##var##_off)
>  
>  /* Relies on boot_command_line being set */
>  void __init parse_early_param(void);

Looks good:

Reviewed-by: Johan Hovold <johan@...nel.org>

Johan