linux-kernel - Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGETcx9YsjPtiBxJEybY5UTWNu-9e=FrYPVd1ORF9hz0M04w5Q@mail.gmail.com>
Date:   Sun, 31 Jan 2021 18:22:37 -0800
From:   Saravana Kannan <saravanak@...gle.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Russell King <linux@...linux.org.uk>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Martin Kaiser <martin@...ser.cx>,
        Android Kernel Team <kernel-team@...roid.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

On Sun, Jan 31, 2021 at 5:26 PM Fabio Estevam <festevam@...il.com> wrote:
>
> Hi Saravana,
>
> On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan <saravanak@...gle.com> wrote:
>
> > +static int __init imx_avic_init(struct device_node *node,
> > +                              struct device_node *parent)
> > +{
> > +       void __iomem *avic_base;
> > +
> > +       avic_base = of_iomap(node, 0);
> > +       BUG_ON(!avic_base);
> > +       mxc_init_irq(avic_base);
> > +       return 0;
> > +}
> > +
> > +IRQCHIP_DECLARE(imx_avic, "fsl,imx31-avic", imx_avic_init);
>
> Shouldn't the compatible be "fsl,avic" instead?

Fabio,

Ah yes. I had that too. I deleted the wrong one in the last minute
before sending it out. Thanks for catching it.

I'll wait to see if there are any other review comments before I send out v2.

Martin,

Please make this fix before you test it.

-Saravana