linux-kernel - Re: [PATCH] bluetooth: fix memory leak in btusb_mtk_wmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <A3F983DE-36C0-43EB-BE8F-086FECCE63B8@holtmann.org>
Date:   Mon, 1 Feb 2021 11:45:02 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jupeng Zhong <zjp734690220@....com>
Cc:     zhongjupeng <zhongjupeng@...ong.com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Bluetooth Kernel Mailing List 
        <linux-bluetooth@...r.kernel.org>, linux-kernel@...r.kernel.org,
        Markus Elfring <Markus.Elfring@....de>
Subject: Re: [PATCH] bluetooth: fix memory leak in btusb_mtk_wmt_recv

Hi Jupeng,

>>>> In btusb_mtk_wmt_recv if skb_clone fails, the alocated skb should
>>>> be released.
>>>> 
>>>> Signed-off-by: zhongjupeng <zhongjupeng@...ong.com>    
>>> 
>>> please provide a proper From: and Signed-off-by line with full name.
>>> 
>>> Regards
>>> 
>>> Marcel  
>> 
>>  Hi,
>> 
>> 
>>    Update the patch From: and Signed-off-by: as follows:
>> 
>> 	Jupeng Zhong <zhongjupeng@...ong.com>
> 
> 
>  Hi,
> 
>    Thanks to Markus Elfring for the suggestion:
> 
>    1. add the tag “Fixes”.
>    2. omit the labels “err_out” and “err_free_skb” in this function
>       implementation.
> 
>    The patch has been updated, please check.
> 
>    Thanks.
> <0001-Bluetooth-btusb-Fix-memory-leak-in-btusb_mtk_wmt_rec.patch>

please send patch inline via git-send-email or similar so that they are easy to review.

Regards

Marcel