linux-kernel - Re: [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on ARM_SMMU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98ce3401-cac9-2111-5ae5-082808a6edc4@arm.com>
Date:   Mon, 1 Feb 2021 11:48:18 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     John Garry <john.garry@...wei.com>, will@...nel.org,
        mark.rutland@....com
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        jean-philippe@...aro.org, thunder.leizhen@...wei.com,
        shameerali.kolothum.thodi@...wei.com
Subject: Re: [PATCH] driver/perf: Remove ARM_SMMU_V3_PMU dependency on
 ARM_SMMU_V3

On 2021-02-01 10:24, John Garry wrote:
> The ARM_SMMU_V3_PMU dependency on ARM_SMMU_V3_PMU was added with the idea
> that a SMMUv3 PMCG would only exist on a system with an associated SMMUv3.
> 
> However it is not the job of Kconfig to make these sorts of decisions (even
> if it were true), so remove the dependency.

Reviewed-by: Robin Murphy <robin.murphy@....com>

> Signed-off-by: John Garry <john.garry@...wei.com>
> 
> diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig
> index 3075cf171f78..77522e5efe11 100644
> --- a/drivers/perf/Kconfig
> +++ b/drivers/perf/Kconfig
> @@ -62,7 +62,7 @@ config ARM_PMU_ACPI
>   
>   config ARM_SMMU_V3_PMU
>   	 tristate "ARM SMMUv3 Performance Monitors Extension"
> -	 depends on ARM64 && ACPI && ARM_SMMU_V3
> +	 depends on ARM64 && ACPI
>   	   help
>   	   Provides support for the ARM SMMUv3 Performance Monitor Counter
>   	   Groups (PMCG), which provide monitoring of transactions passing
>