linux-kernel - Re: [PATCH] media: i2c: fix odd_ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210201130447.GN32460@paasikivi.fi.intel.com>
Date:   Mon, 1 Feb 2021 15:04:47 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>
Cc:     Julia Lawall <julia.lawall@...ia.fr>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org,
        Kévin L'hôpital <kevin.lhopital@...tlin.com>,
        linux-kernel@...r.kernel.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        kbuild-all@...ts.01.org
Subject: Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings

On Mon, Jan 18, 2021 at 02:55:07PM +0100, Paul Kocialkowski wrote:
> Hi,
> 
> On Sat 16 Jan 21, 21:11, Julia Lawall wrote:
> > From: kernel test robot <lkp@...el.com>
> > 
> > PTR_ERR should access the value just tested by IS_ERR
> 
> Good catch!
> 
> Reviewed-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>

Thanks, Julia and Paul.

A patch with similar content got recently merged:

commit 6e7cca2790a54057ddf64da7843271e192f71ca0
Author: Hans Verkuil <hverkuil-cisco@...all.nl>
Date:   Wed Jan 20 09:42:38 2021 +0100

    media: i2c/ov8865.c: fix error checks using wrong variable
    
    Fix two typos: dvdd -> dovdd and dvdd -> avdd
    
    Both clearly copy-and-paste mistakes.
    
    Fixes this smatch warning:
    
    drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'PTR_ERR'
    
    Signed-off-by: Hans Verkuil <hverkuil-cisco@...all.nl>
    Reported-by: kernel test robot <lkp@...el.com>
    Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

-- 
Kind regards,

Sakari Ailus