linux-kernel - Re: [RESEND PATCH v2] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 1 Feb 2021 17:06:06 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     eli.billauer@...il.com
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [RESEND PATCH v2] char: xillybus: Add driver for XillyUSB
 (Xillybus variant for USB)

On Mon, Feb 01, 2021 at 05:56:19PM +0200, eli.billauer@...il.com wrote:
> From: Eli Billauer <eli.billauer@...il.com>
> 
> The XillyUSB driver is the USB variant for the Xillybus FPGA IP core.
> Even though it presents a nearly identical API on the FPGA and host,
> it's almost a complete rewrite of the driver: The framework for exchanging
> data on a USB bus is fundamentally different from doing the same with a
> PCIe interface, which leaves very little in common between the existing
> driver and the new one for XillyUSB.
> 
> Signed-off-by: Eli Billauer <eli.billauer@...il.com>
> ---
> 
> Notes:
>     Changelog:
>     
>     v2:
>       - Add comment in Kconfig file, saying XILLYUSB really doesn't depend
>         on XILLYBUS (following comment by Randy Dunlap)
>     
>       - Use SEEK_* predefined constants instead of numbers

As brought up on the other list, this should either:
	- use the same device nodes as the existing xillybus drivers do,
	  as you have the same api
	- just do it all in userspace using libusb.

thanks,

greg k-h