linux-kernel - Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable fw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09502076-02e9-39ee-e432-24260696a927@gmail.com>
Date:   Mon, 1 Feb 2021 19:49:25 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Marc Zyngier <maz@...nel.org>,
        Jisheng Zhang <Jisheng.Zhang@...aptics.com>,
        Kever Yang <kever.yang@...k-chips.com>,
        Android Kernel Team <kernel-team@...roid.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v5] gpiolib: Bind gpio_device to a driver to enable
 fw_devlink=on by default

01.02.2021 00:28, Saravana Kannan пишет:
>> This patch causes these new errors on NVIDIA Tegra30 Nexus 7 using recent linux-next:
>>
>>  gpio-1022 (cpu-pwr-req-hog): hogged as input
>>  max77620-pinctrl max77620-pinctrl: pin gpio4 already requested by max77620-pinctrl; cannot claim for gpiochip1
>>  max77620-pinctrl max77620-pinctrl: pin-4 (gpiochip1) status -22
>>  max77620-pinctrl max77620-pinctrl: could not request pin 4 (gpio4) from group gpio4  on device max77620-pinctrl
>>  gpio_stub_drv gpiochip1: Error applying setting, reverse things back
>>  gpio_stub_drv: probe of gpiochip1 failed with error -22
>>
>> Please fix, thanks in advance.
> I have a partial guess on why this is happening. So can you try this patch?
> 
> Thanks,
> Saravana
> 
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -4213,6 +4213,8 @@ static int gpio_stub_drv_probe(struct device *dev)
>          * gpio_device of the GPIO chip with the firmware node and then simply
>          * bind it to this stub driver.
>          */
> +       if (dev->fwnode && dev->fwnode->dev != dev)
> +               return -EBUSY;
>         return 0;
>  }

This change doesn't help, exactly the same errors are still there.