linux-kernel - Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <139adb14-f75a-25ef-06da-e87729c2ccf2@linux.ibm.com>
Date:   Mon, 1 Feb 2021 12:08:45 -0500
From:   Matthew Rosato <mjrosato@...ux.ibm.com>
To:     Cornelia Huck <cohuck@...hat.com>,
        Max Gurtovoy <mgurtovoy@...dia.com>
Cc:     jgg@...dia.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        alex.williamson@...hat.com, liranl@...dia.com, oren@...dia.com,
        tzahio@...dia.com, leonro@...dia.com, yarong@...dia.com,
        aviadye@...dia.com, shahafs@...dia.com, artemp@...dia.com,
        kwankhede@...dia.com, ACurrid@...dia.com, gmataev@...dia.com,
        cjia@...dia.com, yishaih@...dia.com, aik@...abs.ru
Subject: Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue

On 2/1/21 11:52 AM, Cornelia Huck wrote:
> On Mon, 1 Feb 2021 16:28:25 +0000
> Max Gurtovoy <mgurtovoy@...dia.com> wrote:
> 
>> In case allocation fails, we must behave correctly and exit with error.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@...dia.com>
> 
> Fixes: e6b817d4b821 ("vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO")
> 
> Reviewed-by: Cornelia Huck <cohuck@...hat.com>
> 
> I think this should go in independently of this series. >

Agreed, makes sense to me -- thanks for finding.

Reviewed-by: Matthew Rosato <mjrosato@...ux.ibm.com>

>> ---
>>   drivers/vfio/pci/vfio_pci_zdev.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>