lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAE1WUT56=3hvwdDjdJP1yAOYM8P_wP2zEGwcV+NDx9ia7xWPAQ@mail.gmail.com> Date: Mon, 1 Feb 2021 16:09:03 -0800 From: Amy Parker <enbyamy@...il.com> To: Alex Elder <elder@...aro.org> Cc: davem@...emloft.net, kuba@...nel.org, elder@...nel.org, evgreen@...omium.org, bjorn.andersson@...aro.org, cpratapa@...eaurora.org, subashab@...eaurora.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net 1/4] net: ipa: add a missing __iomem attribute On Mon, Feb 1, 2021 at 3:29 PM Alex Elder <elder@...aro.org> wrote: > > The virt local variable in gsi_channel_state() does not have an > __iomem attribute but should. Fix this. > > Signed-off-by: Alex Elder <elder@...aro.org> > --- > drivers/net/ipa/gsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c > index 14d9a791924bf..e2e77f09077a9 100644 > --- a/drivers/net/ipa/gsi.c > +++ b/drivers/net/ipa/gsi.c > @@ -440,7 +440,7 @@ static void gsi_evt_ring_de_alloc_command(struct gsi *gsi, u32 evt_ring_id) > static enum gsi_channel_state gsi_channel_state(struct gsi_channel *channel) > { > u32 channel_id = gsi_channel_id(channel); > - void *virt = channel->gsi->virt; > + void __iomem *virt = channel->gsi->virt; > u32 val; > > val = ioread32(virt + GSI_CH_C_CNTXT_0_OFFSET(channel_id)); > -- > 2.27.0 > Seems pretty straightforward to me, ioread32 expects an __iomem-annotated pointer. Reviewed-by: Amy Parker <enbyamy@...il.com>
Powered by blists - more mailing lists