linux-kernel - Re: [PATCH v2] Bluetooth: btusb: Fix memory leak in btusb_mtk_wmt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 17:26:55 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Jupeng Zhong <zjp734690220@....com>
Cc:     Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Markus.Elfring@....de, linux-bluetooth@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jupeng Zhong <zhongjupeng@...ong.com>
Subject: Re: [PATCH v2] Bluetooth: btusb: Fix memory leak in
 btusb_mtk_wmt_recv

Hi Jupeng,

> In btusb_mtk_wmt_recv if skb_clone fails, the alocated skb should be
> released.
> 
> Omit the labels “err_out” and “err_free_skb” in this function
> implementation so that the desired exception handling code
> would be directly specified in the affected if branches.
> 
> Fixes: a1c49c434e15 ("btusb: Add protocol support for MediaTek MT7668U USB devices")
> Signed-off-by: Jupeng Zhong <zhongjupeng@...ong.com>
> ---
> drivers/bluetooth/btusb.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)

patch does not apply cleanly to bluetooth-next tree. Please rebase.

Regards

Marcel