linux-kernel - Re: [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 1 Feb 2021 16:11:52 -0800
From:   Amy Parker <enbyamy@...il.com>
To:     Claus Stovgaard <claus.stovgaard@...il.com>
Cc:     linux-nvme@...ts.infradead.org, Keith Busch <kbusch@...nel.org>,
        Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme-pci: Mark Phison E16 (Corsair MP600) as IGNORE_DEV_SUBNQN

On Mon, Feb 1, 2021 at 1:11 PM Claus Stovgaard
<claus.stovgaard@...il.com> wrote:
>
> Tested both with Corsairs firmware 11.3 and 13.0 for the MP600 and both
> have the issue as reported by the kernel.
>
> nvme nvme0: missing or invalid SUBNQN field.
>
> Signed-off-by: Claus Stovgaard <claus.stovgaard@...il.com>
> ---
>  drivers/nvme/host/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 81e6389b2042..41b1b0731cbd 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3242,6 +3242,8 @@ static const struct pci_device_id nvme_id_table[] = {
>         { PCI_DEVICE(0x144d, 0xa822),   /* Samsung PM1725a */
>                 .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY |
>                                 NVME_QUIRK_IGNORE_DEV_SUBNQN, },
> +       { PCI_DEVICE(0x1987, 0x5016),   /* Phison E16 (Corsair MP600) */
> +               .driver_data = NVME_QUIRK_IGNORE_DEV_SUBNQN, },
>         { PCI_DEVICE(0x1d1d, 0x1f1f),   /* LighNVM qemu device */
>                 .driver_data = NVME_QUIRK_LIGHTNVM, },
>         { PCI_DEVICE(0x1d1d, 0x2807),   /* CNEX WL */
> --
> 2.26.2
>

Can't test this - don't have an MP600 of my own to test with - but it
should work just fine. If anyone else has an MP600 to throw at this
that'd be great.

Acked-by: Amy Parker <enbyamy@...il.com>

Best regards,
Amy Parker
(she/her/hers)