[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 02 Feb 2021 11:44:54 -0600
From: Rob Herring <robh@...nel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc: Sascha Hauer <s.hauer@...gutronix.de>,
linux-kernel@...r.kernel.org,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Jaehoon Chung <jh80.chung@...sung.com>,
Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
Andy Gross <agross@...nel.org>,
Jesper Nilsson <jesper.nilsson@...s.com>,
Kishon Vijay Abraham I <kishon@...com>,
Thierry Reding <thierry.reding@...il.com>,
linux-amlogic@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org,
Lucas Stach <l.stach@...gutronix.de>,
linux-samsung-soc@...r.kernel.org,
Kevin Hilman <khilman@...libre.com>,
devicetree@...r.kernel.org,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
linux-arm-kernel@...s.com, Richard Zhu <hongxing.zhu@....com>,
linux-arm-msm@...r.kernel.org,
Neil Armstrong <narmstrong@...libre.com>,
Fabio Estevam <festevam@...il.com>,
Shawn Guo <shawnguo@...nel.org>,
Jonathan Hunter <jonathanh@...dia.com>,
NXP Linux Team <linux-imx@....com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
linux-pci@...r.kernel.org, Jerome Brunet <jbrunet@...libre.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
linux-omap@...r.kernel.org, Jingoo Han <jingoohan1@...il.com>,
linux-tegra@...r.kernel.org, Jonathan Chocron <jonnyc@...zon.com>,
Zhou Wang <wangzhou1@...ilicon.com>,
Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH 01/13] doc: bindings: pci: designware-pcie.txt: convert it to yaml
On Tue, 02 Feb 2021 14:29:46 +0100, Mauro Carvalho Chehab wrote:
> Convert the file into a DT schema.
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
> ---
> .../bindings/pci/amlogic,meson-pcie.txt | 4 +-
> .../bindings/pci/axis,artpec6-pcie.txt | 2 +-
> .../bindings/pci/designware-pcie.txt | 77 ----------
> .../bindings/pci/fsl,imx6q-pcie.txt | 2 +-
> .../bindings/pci/hisilicon-histb-pcie.txt | 2 +-
> .../bindings/pci/hisilicon-pcie.txt | 2 +-
> .../devicetree/bindings/pci/kirin-pcie.txt | 2 +-
> .../bindings/pci/layerscape-pci.txt | 2 +-
> .../bindings/pci/nvidia,tegra194-pcie.txt | 4 +-
> .../devicetree/bindings/pci/pci-armada8k.txt | 2 +-
> .../devicetree/bindings/pci/pci-keystone.txt | 10 +-
> .../devicetree/bindings/pci/pcie-al.txt | 2 +-
> .../devicetree/bindings/pci/qcom,pcie.txt | 14 +-
> .../bindings/pci/samsung,exynos-pcie.yaml | 2 +-
> .../devicetree/bindings/pci/snps,pcie.yaml | 139 ++++++++++++++++++
> .../pci/socionext,uniphier-pcie-ep.yaml | 2 +-
> .../devicetree/bindings/pci/ti-pci.txt | 4 +-
> .../devicetree/bindings/pci/uniphier-pcie.txt | 2 +-
> MAINTAINERS | 2 +-
> 19 files changed, 169 insertions(+), 107 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pci/designware-pcie.txt
> create mode 100644 Documentation/devicetree/bindings/pci/snps,pcie.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/snps,pcie.yaml: properties:snps,enable-cdm-check: 'oneOf' conditional failed, one must be fixed:
'type' is a required property
Additional properties are not allowed ('$ref' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/snps,pcie.yaml: properties:snps,enable-cdm-check: 'oneOf' conditional failed, one must be fixed:
'enum' is a required property
'const' is a required property
'/schemas/types.yaml#definitions/flag' does not match 'types.yaml#/definitions/'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pci/snps,pcie.yaml: ignoring, error in schema: properties: snps,enable-cdm-check
warning: no schema found in file: ./Documentation/devicetree/bindings/pci/snps,pcie.yaml
See https://patchwork.ozlabs.org/patch/1434686
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
Powered by blists - more mailing lists