linux-kernel - Re: [PATCH RESEND v4 0/4] x86: fix get_nr_restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 10:15:21 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Oleg Nesterov <oleg@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andy Lutomirski <luto@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Jan Kratochvil <jan.kratochvil@...hat.com>,
        Pedro Alves <palves@...hat.com>, Peter Anvin <hpa@...or.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [PATCH RESEND v4 0/4] x86: fix get_nr_restart_syscall()

On Tue, Feb 2, 2021 at 7:56 AM Oleg Nesterov <oleg@...hat.com> wrote:
>
> There is the "erestartsys-trap-debugger" test in ptrace-tests suite.
> Do you mean you want another test in tools/testing/selftests/ptrace ?

No, I guess it's fine if it's caught by the ptrace test suite - we'll
hopefully get fairly timely "guys, you broke it" reports.

Is that ptrace erestartsys-trap-debugger.c test new, or has it just
always failed? Or is the problem that it is so expected to fail that
we wouldn't get reports of it anyway (this clearly fell off your radar
for a long time)?

IOW, my only worry is that this is somewhat subtle (understatement of
the year), has been around forever, and if we care about this debugger
case, we should have _some_ way to make sure that if it gets broken
again we at least get notified some way in a reasonably timely
manner...

               Linus