[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 1 Feb 2021 20:27:53 -0800
From: Moritz Fischer <mdf@...nel.org>
To: richard.gong@...ux.intel.com
Cc: mdf@...nel.org, trix@...hat.com, gregkh@...uxfoundation.org,
linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
Richard Gong <richard.gong@...el.com>
Subject: Re: [PATCHv4 5/6] dt-bindings: fpga: add authenticate-fpga-config
property
On Mon, Feb 01, 2021 at 09:21:58AM -0600, richard.gong@...ux.intel.com wrote:
> From: Richard Gong <richard.gong@...el.com>
>
> Add authenticate-fpga-config property for FPGA bitstream authentication,
> which makes sure a signed bitstream has valid signatures.
>
> Signed-off-by: Richard Gong <richard.gong@...el.com>
> ---
> v4: explain authenticate-fpga-config flag further
> v3: no change
> v2: put authenticate-fpga-config above partial-fpga-config
> update commit messages
> ---
> Documentation/devicetree/bindings/fpga/fpga-region.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/fpga/fpga-region.txt b/Documentation/devicetree/bindings/fpga/fpga-region.txt
> index e811cf8..e2740b6 100644
> --- a/Documentation/devicetree/bindings/fpga/fpga-region.txt
> +++ b/Documentation/devicetree/bindings/fpga/fpga-region.txt
> @@ -182,6 +182,10 @@ Optional properties:
> This property is optional if the FPGA Manager handles the bridges.
> If the fpga-region is the child of a fpga-bridge, the list should not
> contain the parent bridge.
> +- authenticate-fpga-config : boolean, set if do bitstream authentication only.
> + flag authenticate-fpga-config is used to first check the integrity of
> + the bitstream. If the authentication is passed, the user can perform
> + other operations.
>From the other commits it looks like it *also* writes to QSPI? If so
please document that.
If not, feel free to ignore :)
Maybe I would highlight two things:
a) If you add 'authenticate-fpga-config' you are not allowed to add new
nodes
b) If you add 'authenticate-fpga-config' you are not alllowed to add
other operations
> - partial-fpga-config : boolean, set if partial reconfiguration is to be done,
> otherwise full reconfiguration is done.
> - external-fpga-config : boolean, set if the FPGA has already been configured
> --
> 2.7.4
>
Thanks,
Moritz
Powered by blists - more mailing lists