linux-kernel - Re: [PATCH v2] smackfs: restrict bytes count in smackfs write functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210202191318.1402500-1-snovitoll@gmail.com>
Date:   Wed,  3 Feb 2021 01:13:18 +0600
From:   Sabyrzhan Tasbolatov <snovitoll@...il.com>
To:     casey@...aufler-ca.com
Cc:     andreyknvl@...gle.com, jmorris@...ei.org,
        linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org, mhocko@...e.com,
        penguin-kernel@...ove.sakura.ne.jp, serge@...lyn.com,
        snovitoll@...il.com,
        syzbot+a71a442385a0b2815497@...kaller.appspotmail.com
Subject: Re: [PATCH v2] smackfs: restrict bytes count in smackfs write functions

> if PAGE_SIZE >= SMK_LOADSIZE all legitimate requests can be made
> using PAGE_SIZE as a limit. Your example with 19990 spaces before
> the data demonstrates that the interface is inadequately documented.
> Tizen and Automotive Grade Linux are going to be fine with a PAGE_SIZE
> limit. The best way to address this concern is to go ahead with the
> PAGE_SIZE limit and create ABI documents for the smackfs interfaces.
> I will take your patch for the former and create a patch for the latter.

Please let me know if there is anything else required for this patch.
AFAIU, we agreed with PAGE_SIZE as the limit.