[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 2 Feb 2021 20:15:26 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Mohamed Mediouni <mohamed.mediouni@...amail.com>
Cc: Linux ARM <linux-arm-kernel@...ts.infradead.org>,
Mark Rutland <mark.rutland@....com>,
Catalin Marinas <catalin.marinas@....com>,
Hector Martin <marcan@...can.st>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Marc Zyngier <maz@...nel.org>, Will Deacon <will@...nel.org>,
Stan Skowronek <stan@...ellium.com>
Subject: Re: [RFC PATCH 7/7] irqchip/apple-aic: add SMP support to the Apple
AIC driver.
Hi Mohamed,
just a small drive-by comment:
On Wed, Jan 20, 2021 at 2:32 PM Mohamed Mediouni
<mohamed.mediouni@...amail.com> wrote:
> + for_each_cpu (cpu, mask) {
> + smp_mb__before_atomic();
> + atomic_or(1u << irqnr, per_cpu_ptr(&aic_ipi_mask, cpu));
Use:
#include <linux/bits.h>
atomic_or(BIT(irqnr), per_cpu_ptr(&aic_ipi_mask, cpu));
Yours,
Linus Walleij
Powered by blists - more mailing lists