linux-kernel - Re: [PATCH] ASoC: Intel: catpt: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 20:45:46 +0100
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>, perex@...ex.cz
Cc:     tiwai@...e.com, broonie@...nel.org, yang.jie@...ux.intel.com,
        liam.r.girdwood@...ux.intel.com,
        pierre-louis.bossart@...ux.intel.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: Intel: catpt: remove unneeded semicolon

On 2021-02-01 10:03 PM, Cezary Rojewski wrote:
> On 2021-02-01 9:01 AM, Yang Li wrote:
>> Eliminate the following coccicheck warning:
>> ./sound/soc/intel/catpt/pcm.c:355:2-3: Unneeded semicolon
>>
>> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
>> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
>> ---
>>   sound/soc/intel/catpt/pcm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sound/soc/intel/catpt/pcm.c b/sound/soc/intel/catpt/pcm.c
>> index e5d54bb..88a0879 100644
>> --- a/sound/soc/intel/catpt/pcm.c
>> +++ b/sound/soc/intel/catpt/pcm.c
>> @@ -352,7 +352,7 @@ static int catpt_dai_apply_usettings(struct 
>> snd_soc_dai *dai,
>>           break;
>>       default:
>>           return 0;
>> -    };
>> +    }
>>       list_for_each_entry(pos, &component->card->snd_card->controls, 
>> list) {
>>           if (pos->private_data == component &&
>>
> 
> Hello Yang,
> 
> Your patch is much appreciated.
> 
> I noticed that more mistakes such as this have been made in the code. 
> Could you please also update switch-statements in other parts of catpt 
> (from what I've found, pcm.c has 2 occurrences while loader.c has 1)?
> 

I see now. Patch [1] provided the fixes already but optimization of mine 
[2] done later, overridden part of it. In that case, there's nothing 
else to be done.

Acked-by: Cezary Rojewski <cezary.rojewski@...el.com>

Regards,
Czarek


[1]: https://lore.kernel.org/r/20201101171943.2305030-1-trix@redhat.com
[2]: 
https://lore.kernel.org/r/20201116133332.8530-4-cezary.rojewski@intel.com