linux-kernel - [PATCH -next] PCI: endpoint: fix build error, EP NTB driver uses configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  2 Feb 2021 12:12:55 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     linux-kernel@...r.kernel.org
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-pci@...r.kernel.org
Subject: [PATCH -next] PCI: endpoint: fix build error, EP NTB driver uses configfs

The pci-epf-ntb driver uses configfs APIs, so it should depend on
CONFIGFS_FS to prevent build errors.

ld: drivers/pci/endpoint/functions/pci-epf-ntb.o: in function `epf_ntb_add_cfs':
pci-epf-ntb.c:(.text+0x1b): undefined reference to `config_group_init_type_name'

Fixes: 7dc64244f9e9 ("PCI: endpoint: Add EP function driver to provide NTB functionality")

Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
Cc: Kishon Vijay Abraham I <kishon@...com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@....com>
Cc: linux-pci@...r.kernel.org
---
You may switch to 'select CONFIG_FS_FS' if you feel strongly about it.

 drivers/pci/endpoint/functions/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20210202.orig/drivers/pci/endpoint/functions/Kconfig
+++ linux-next-20210202/drivers/pci/endpoint/functions/Kconfig
@@ -16,6 +16,7 @@ config PCI_EPF_TEST
 config PCI_EPF_NTB
 	tristate "PCI Endpoint NTB driver"
 	depends on PCI_ENDPOINT
+	depends on CONFIGFS_FS
 	help
 	  Select this configuration option to enable the NTB driver
 	  for PCI Endpoint. NTB driver implements NTB controller