linux-kernel - Re: [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 15:10:22 -0600
From:   Rob Herring <robh@...nel.org>
To:     Lars-Peter Clausen <lars@...afoo.de>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Michael Auchter <michael.auchter@...com>,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible
 strings

On Tue, Feb 02, 2021 at 09:55:56PM +0100, Lars-Peter Clausen wrote:
> On 2/2/21 7:14 PM, Rob Herring wrote:
> > The example uses 'adi,ad5686', but the schema fails to document it. Given
> > the filename and there is a similar part AD5686, let's just add the
> > compatible strings including the 'r' variant.
> 
> There are two variants of this chip. One with a SPI interface and one with a
> I2C interface. This binding document only describes the I2C variants. But
> the ad5686 is a SPI variant.

Right, I should have noticed that.

> I think this is a typo and we should replace ad5686 with ad5696, including
> the document name.

Though we do frequently document both I2C and SPI variants in the same 
binding, given there's no existing SPI support and the example is wrong 
I agree.

> > 
> > Cc: Lars-Peter Clausen <lars@...afoo.de>
> > Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> > Cc: Jonathan Cameron <jic23@...nel.org>
> > Cc: Peter Meerwald-Stadler <pmeerw@...erw.net>
> > Cc: Michael Auchter <michael.auchter@...com>
> > Cc: linux-iio@...r.kernel.org
> > Signed-off-by: Rob Herring <robh@...nel.org>
> > ---
> >   Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> > index 8065228e5df8..190919291828 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> > @@ -19,6 +19,8 @@ properties:
> >         - adi,ad5338r
> >         - adi,ad5671r
> >         - adi,ad5675r
> > +      - adi,ad5686
> > +      - adi,ad5686r
> >         - adi,ad5691r
> >         - adi,ad5692r
> >         - adi,ad5693
> 
>