linux-kernel - Re: [PATCH v2] dt-bindings: iio: dac: Fix AD5686 references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 22:56:21 +0100
From:   Lars-Peter Clausen <lars@...afoo.de>
To:     Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Michael Auchter <michael.auchter@...com>,
        linux-iio@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: iio: dac: Fix AD5686 references

On 2/2/21 10:55 PM, Rob Herring wrote:
> The example and filename use 'adi,ad5686', but the schema doesn't
> document it. The AD5686 is also a SPI interface variant while all the
> documented variants have an I2C interface. So let's update all the
> references to AD5686 to AD5696.
>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: Peter Meerwald-Stadler <pmeerw@...erw.net>
> Cc: Michael Auchter <michael.auchter@...com>
> Cc: linux-iio@...r.kernel.org
> Signed-off-by: Rob Herring <robh@...nel.org>

Acked-by: Lars-Peter Clausen <lars@...afoo.de>

Thanks Rob.

> ---
> v2:
> - Rename instead of adding AD5686
>
>   .../iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml}       | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>   rename Documentation/devicetree/bindings/iio/dac/{adi,ad5686.yaml => adi,ad5696.yaml} (77%)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> similarity index 77%
> rename from Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> rename to Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> index 8065228e5df8..56b0cda0f30a 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5696.yaml
> @@ -1,16 +1,16 @@
>   # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>   %YAML 1.2
>   ---
> -$id: http://devicetree.org/schemas/iio/dac/adi,ad5686.yaml#
> +$id: http://devicetree.org/schemas/iio/dac/adi,ad5696.yaml#
>   $schema: http://devicetree.org/meta-schemas/core.yaml#
>   
> -title: Analog Devices AD5686 and similar multi-channel DACs
> +title: Analog Devices AD5696 and similar multi-channel DACs
>   
>   maintainers:
>     - Michael Auchter <michael.auchter@...com>
>   
>   description: |
> -  Binding for Analog Devices AD5686 and similar multi-channel DACs
> +  Binding for Analog Devices AD5696 and similar multi-channel DACs
>   
>   properties:
>     compatible:
> @@ -48,8 +48,8 @@ examples:
>         #address-cells = <1>;
>         #size-cells = <0>;
>   
> -      ad5686: dac@0 {
> -        compatible = "adi,ad5686";
> +      ad5696: dac@0 {
> +        compatible = "adi,ad5696";
>           reg = <0>;
>           vcc-supply = <&dac_vref>;
>         };