[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 2 Feb 2021 15:28:01 +0800
From: Joseph Qi <joseph.qi@...ux.alibaba.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
akpm <akpm@...ux-foundation.org>
Cc: jlbec@...lplan.org, ocfs2-devel@....oracle.com,
linux-kernel@...r.kernel.org, Mark Fasheh <mark@...heh.com>
Subject: Re: [PATCH] ocfs2: Simplify the calculation of variables
On 2/2/21 11:10 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./fs/ocfs2/refcounttree.c:981:16-18: WARNING !A || A && B is equivalent
> to !A || B.
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Reviewed-by: Joseph Qi <joseph.qi@...ux.alibaba.com>
> ---
> fs/ocfs2/refcounttree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
> index 3b397fa..115365e85 100644
> --- a/fs/ocfs2/refcounttree.c
> +++ b/fs/ocfs2/refcounttree.c
> @@ -978,7 +978,7 @@ static int ocfs2_get_refcount_cpos_end(struct ocfs2_caching_info *ci,
> return 0;
> }
>
> - if (!eb || (eb && !eb->h_next_leaf_blk)) {
> + if (!eb || !eb->h_next_leaf_blk) {
> /*
> * We are the last extent rec, so any high cpos should
> * be stored in this leaf refcount block.
>
Powered by blists - more mailing lists