linux-kernel - Re: [PATCH v1] usb: typec: tcpm: Set in_ams flag when Source caps have been received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 10:25:09 +0200
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Kyle Tso <kyletso@...gle.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Set in_ams flag when Source caps
 have been received

On Mon, Feb 01, 2021 at 07:38:59PM -0800, Badhri Jagan Sridharan wrote:
> Receiving the first packet in an AMS sequence signals the
> beginning of AMS. Set in_ams flag to true when SRC_CAPS are
> received during POWER_NEGOTIATION AMS.
> This fixes the failure flagged while running TD.PD.SNK.E9
> compliance test.
> 
> >From Deterministic PD compliance MOI spec:
> TD.PD.SNK.E9. GetSinkCap in Place of Accept
> Description:
> As Provider, the Tester intentionally sends a GetSinkCap message in place
> of Accept message and verifies the UUT will send a SoftReset and recover
> from the error.
> Steps:
> a) Run PROC.PD.E1 Bring-up according to the UUT role.
> b) The Tester cycles VBus.
> c) The Tester sends a Source Capabilities message to the UUT.
> d) Upon receipt of a Request message from the UUT, the Tester replies with
>    a GoodCRC message.
> e) The Tester sends a GetSinkCap message to the UUT.
> f) If a SoftReset is not received within 15 ms after the GetSinkCap EOP was
>    sent, the test fails.
> g) If a SoftReset is received timely, the Tester replies with an Accept
>    message.
> h) The Tester sends Source Capabilities message to the UUT repeatedly until
>    nCapsCount reached or a GoodCRC is received. If nCapsCount reached, the
>    test fails.
> i) If a Request is not received timely within 30 ms after the GoodCRC EOP
>    corresponding to Source Capabilities message was received, the test
>    fails.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 0afd8ef692e8..b3e07d9b7597 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -2243,6 +2243,7 @@ static void tcpm_pd_data_request(struct tcpm_port *port,
>  		 * handled.
>  		 */
>  			port->ams = POWER_NEGOTIATION;
> +			port->in_ams = true;
>  			tcpm_set_state(port, SNK_NEGOTIATE_CAPABILITIES, 0);
>  		} else {
>  			if (port->ams == GET_SOURCE_CAPABILITIES)
> -- 
> 2.30.0.365.g02bc693789-goog

thanks,

-- 
heikki