linux-kernel - Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 02 Feb 2021 09:50:54 +0106
From:   John Ogness <john.ogness@...utronix.de>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        linux-kernel@...r.kernel.org, Petr Mladek <pmladek@...e.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     Masahiro Yamada <masahiroy@...nel.org>
Subject: Re: [PATCH 3/3] printk: move CONSOLE_EXT_LOG_MAX to kernel/printk/printk.c

On 2021-02-02, Masahiro Yamada <masahiroy@...nel.org> wrote:
> This macro is only used in kernel/printk/printk.c

I recently posted a patch [0] that added another macro CONSOLE_LOG_MAX
here. But it also is only used in printk.c. I see no reason why either
should be in the header. Neither my patch nor commit d43ff430f434
("printk: guard the amount written per line by devkmsg_read()") show any
motivation for using printk.h.

I am fine with moving them out. The only consequences could be
out-of-tree modules breaking, but do we care about that?

John Ogness

[0] https://lkml.kernel.org/r/20210126211551.26536-5-john.ogness@linutronix.de