linux-kernel - Re: [PATCH] mm/memcontrol: remove redundant NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 11:12:05 +0100
From:   David Hildenbrand <david@...hat.com>
To:     Yang Li <abaci-bugfix@...ux.alibaba.com>, hannes@...xchg.org
Cc:     mhocko@...nel.org, vdavydov.dev@...il.com,
        akpm@...ux-foundation.org, cgroups@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memcontrol: remove redundant NULL check

On 21.01.21 09:00, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./mm/memcontrol.c:451:3-9: WARNING: NULL check before some freeing
> functions is not needed.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <abaci-bugfix@...ux.alibaba.com>
> ---
>   mm/memcontrol.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 605f671..f6a561b 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -447,8 +447,7 @@ static void memcg_free_shrinker_maps(struct mem_cgroup *memcg)
>   	for_each_node(nid) {
>   		pn = mem_cgroup_nodeinfo(memcg, nid);
>   		map = rcu_dereference_protected(pn->shrinker_map, true);
> -		if (map)
> -			kvfree(map);
> +		kvfree(map);
>   		rcu_assign_pointer(pn->shrinker_map, NULL);
>   	}
>   }
> 

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb