[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 2 Feb 2021 11:15:55 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
cc: Benjamin Tissoires <benjamin.tissoires@...hat.com>,
Peter Hutterer <peter.hutterer@...-t.net>,
seobrien@...omium.org, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: hid-input: avoid splitting keyboard, system and
consumer controls
On Wed, 13 Jan 2021, Dmitry Torokhov wrote:
> A typical USB keyboard usually splits its keys into several reports:
>
> - one for the basic alphanumeric keys, modifier keys, F<n> keys, six pack
> keys and keypad. This report's application is normally listed as
> GenericDesktop.Keyboard
> - a GenericDesktop.SystemControl report for the system control keys, such
> as power and sleep
> - Consumer.ConsumerControl report for multimedia (forward, rewind,
> play/pause, mute, etc) and other extended keys.
> - additional output, vendor specific, and feature reports
>
> Splitting each report into a separate input device is wasteful and even
> hurts userspace as it makes it harder to determine the true capabilities
> (set of available keys) of a keyboard, so let's adjust application
> matching to merge system control and consumer control reports with
> keyboard report, if one has already been processed.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
Queued in for-5.12/core. Thanks,
--
Jiri Kosina
SUSE Labs
Powered by blists - more mailing lists