linux-kernel - RE: [PATCH v4 3/4] perf tools: Fix lexical definition of event name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 2 Feb 2021 11:03:49 +0000
From:   "nakamura.shun@...itsu.com" <nakamura.shun@...itsu.com>
To:     'John Garry' <john.garry@...wei.com>,
        "will@...nel.org" <will@...nel.org>,
        "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "leo.yan@...aro.org" <leo.yan@...aro.org>,
        "peterz@...radead.org" <peterz@...radead.org>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "acme@...nel.org" <acme@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "alexander.shishkin@...ux.intel.com" 
        <alexander.shishkin@...ux.intel.com>,
        "jolsa@...hat.com" <jolsa@...hat.com>,
        "namhyung@...nel.org" <namhyung@...nel.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v4 3/4] perf tools: Fix lexical definition of event name

(I missed to include the quotation in the text. Will resend. Sorry about that.)

Hi, John

> > Fix the lexical definition of event name so that the numbers are recognizable.
> >
> > A64FX defines an event name that starts with a number.
> >   - 0inst_commit
> >   - 1inst_commit
> >   - 2inst_commit
> >   - 3inst_commit
> >   - 4inst_commit
> >
> > Signed-off-by: Shunsuke Nakamura <nakamura.shun@...itsu.com>
> 
> eh... I'm not sure if you will encounter other problems, so may be prudent to
> change the event name to not start with a number. Someone else may also advise
> on this.
I have applied this patch and confirmed that the event can be specified correctly.
Event names are defined in the A64FX specification.
I want to deal with it at that time if there is a problem.

So I would like to resend the v5 patch and wait for advice from others.

Best Regards
Shunsuke