lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 3 Feb 2021 08:49:00 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>, jikos@...nel.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
        hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arch: x86: kernel: Mundane spelling fixes throughout the
 file apm_32.c

On 2/3/21 6:48 AM, Bhaskar Chowdhury wrote:
> 
> s/messges/messages/
> s/powermanagement/power management/
> s/secodnds/seconds/
> s/powerdown/poer down/
> 
> Capitalize and truncate space in start of the sentence.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> ---
>  arch/x86/kernel/apm_32.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/kernel/apm_32.c b/arch/x86/kernel/apm_32.c
> index 660270359d39..04204e01ff7c 100644
> --- a/arch/x86/kernel/apm_32.c
> +++ b/arch/x86/kernel/apm_32.c
> @@ -2366,7 +2366,7 @@ static int __init apm_init(void)
>  	/*
>  	 * Note we don't actually care if the misc_device cannot be registered.
>  	 * this driver can do its job without it, even if userspace can't
> -	 * control it.  just log the error
> +	 * control it.Just log the error

missing space and period:

	 * control it. Just log the error.

The rest of the changes look good.

Thanks.

>  	 */
>  	if (misc_register(&apm_device))
>  		printk(KERN_WARNING "apm: Could not register misc device.\n");
> --
> 2.26.2
> 


-- 
~Randy

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ