linux-kernel - Re: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210203172302.GB23019@duo.ucw.cz>
Date:   Wed, 3 Feb 2021 18:23:02 +0100
From:   Pavel Machek <pavel@....cz>
To:     Marek Behun <marek.behun@....cz>
Cc:     Sven Schuchmann <schuchmann@...leissheimer.de>,
        Dan Murphy <dmurphy@...com>, Rob Herring <robh+dt@...nel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

Hi!

> > > If I would not have the default-intensity I would actually see nothing,
> > > since the intensity (which goes from 0-255) of each led is initialized with 0.
> > > 
> > > I hope I could clarify this a little more?  
> > 
> > Yes, sounds reasonable. Could we get default intensity of 100% on all
> > channels if nothing else is specified?
> > 
> > Or maybe simply "if intensity is not specified, start with 100%, and
> > use explicit =0 if other color is expected".
> > 
> > Best regards,
> > 								Pavel
> 
> Is the property default-intensity documented in DT bindings?
> 
> Wouldn't it be better if the property was used in the multi-led node
> instead of the channel node? I.e.
>   multi-led@3 {
>     color = <LED_COLOR_ID_RGB>;
>     default-intensity = <100 0 0>;
>   };

Yes, this would be better.

-- 
http://www.livejournal.com/~pavelmachek

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)