linux-kernel - Re: [PATCH] mailbox: arm_mhuv2: make remove callback return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210203025743.uffbfdjsubsjbfrc@vireshk-i7>
Date:   Wed, 3 Feb 2021 08:27:43 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     Russell King <linux+pull@...linux.org.uk>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tushar Khandelwal <Tushar.Khandelwal@....com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        linux-fbdev@...r.kernel.org, Cornelia Huck <cohuck@...hat.com>,
        kvm@...r.kernel.org, David Airlie <airlied@...ux.ie>,
        Linus Walleij <linus.walleij@...aro.org>,
        alsa-devel@...a-project.org, dri-devel@...ts.freedesktop.org,
        Jaroslav Kysela <perex@...ex.cz>,
        Eric Anholt <eric@...olt.net>,
        Uwe Kleine-König 
        <u.kleine-koenig.org@...gutronix.de>, linux-i2c@...r.kernel.org,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-stm32@...md-mailman.stormreply.com,
        Alexandre Torgue <alexandre.torgue@...com>,
        linux-rtc@...r.kernel.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Takashi Iwai <tiwai@...e.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-serial@...r.kernel.org, linux-input@...r.kernel.org,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Mike Leach <mike.leach@...aro.org>,
        linux-watchdog@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        coresight@...ts.linaro.org, Vladimir Zapolskiy <vz@...ia.com>,
        Eric Auger <eric.auger@...hat.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Mark Brown <broonie@...nel.org>,
        Matt Mackall <mpm@...enic.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Dan Williams <dan.j.williams@...el.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-arm-kernel@...ts.infradead.org,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-spi@...r.kernel.org, Vinod Koul <vkoul@...nel.org>,
        linux-crypto@...r.kernel.org, kernel@...gutronix.de,
        Leo Yan <leo.yan@...aro.org>, dmaengine@...r.kernel.org
Subject: Re: [PATCH] mailbox: arm_mhuv2: make remove callback return void

On 02-02-21, 20:43, Uwe Kleine-König wrote:
> My build tests failed to catch that amba driver that would have needed
> adaption in commit 3fd269e74f2f ("amba: Make the remove callback return
> void"). Change the remove function to make the driver build again.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 3fd269e74f2f ("amba: Make the remove callback return void")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello,
> 
> I guess I missed that driver during rebase as it was only introduced in
> the last merge window. Sorry for that.
> 
> I'm unsure what is the right thing to do now. Should I redo the pull
> request (with this patch squashed into 3fd269e74f2f)? Or do we just
> apply this patch on top?
> 
> FTR, the test robot report is at https://lore.kernel.org/r/202102030343.D9j1wukx-lkp@intel.com
> 
> Best regards
> Uwe
> 
>  drivers/mailbox/arm_mhuv2.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/arm_mhuv2.c b/drivers/mailbox/arm_mhuv2.c
> index 67fb10885bb4..6cf1991a5c9c 100644
> --- a/drivers/mailbox/arm_mhuv2.c
> +++ b/drivers/mailbox/arm_mhuv2.c
> @@ -1095,14 +1095,12 @@ static int mhuv2_probe(struct amba_device *adev, const struct amba_id *id)
>  	return ret;
>  }
>  
> -static int mhuv2_remove(struct amba_device *adev)
> +static void mhuv2_remove(struct amba_device *adev)
>  {
>  	struct mhuv2 *mhu = amba_get_drvdata(adev);
>  
>  	if (mhu->frame == SENDER_FRAME)
>  		writel_relaxed(0x0, &mhu->send->access_request);
> -
> -	return 0;
>  }
>  
>  static struct amba_id mhuv2_ids[] = {

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh