linux-kernel - Re: [PATCH] platform/x86: Move all dell drivers to their own subdirectory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YBr6/ClMRV4Sw/kN@smile.fi.intel.com>
Date:   Wed, 3 Feb 2021 21:35:24 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     Hans De Goede <hdegoede@...hat.com>,
        Mark Gross <mgross@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH] platform/x86: Move all dell drivers to their own
 subdirectory

On Wed, Feb 03, 2021 at 01:26:37PM -0600, Mario Limonciello wrote:
> A user without a Dell system doesn't need to pick any of these
> drivers.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@...l.com>

You are fast, thanks!

...

> +menuconfig DELL_X86_PLATFORM_DRIVERS

I'm not sure this is a good order, rather X86_PLATFORM_DRIVERS_DELL?

...

> +if DELL_X86_PLATFORM_DRIVERS
> +source "drivers/platform/x86/dell/Kconfig"
> +endif # DELL_X86_PLATFORM_DRIVERS

Would you expect something else here?

I would rather unconditionally source this and inside it do that menuconfig
with ifdeffery.

-- 
With Best Regards,
Andy Shevchenko