linux-kernel - Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <702f6f68-7455-337b-e0f3-6947a51c142e@infradead.org>
Date:   Tue, 2 Feb 2021 19:30:23 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Timur Tabi <timur@...nel.org>
Cc:     Petr Mladek <pmladek@...e.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-kernel@...r.kernel.org, vbabka@...e.cz, linux-mm@...ck.org,
        willy@...radead.org, akpm@...ux-foundation.org,
        torvalds@...ux-foundation.org, roman.fietze@...na.com,
        keescook@...omium.org, john.ogness@...utronix.de,
        akinobu.mita@...il.com
Subject: Re: [PATCH][RESEND] lib/vsprintf: make-printk-non-secret printks all
 addresses as unhashed

On 2/2/21 7:24 PM, Sergey Senozhatsky wrote:
> On (21/02/02 15:36), Timur Tabi wrote:
>> If the make-printk-non-secret command-line parameter is set, then
>> printk("%p") will print addresses as unhashed.  This is useful for
>> debugging purposes.
>>
>> A large warning message is displayed if this option is enabled,
>> because unhashed addresses, while useful for debugging, exposes
>> kernel addresses which can be a security risk.
>>
>> Signed-off-by: Timur Tabi <timur@...nel.org>
> 
> Looks good to me.
> 
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 
> 	-ss

Acked-by: Randy Dunlap <rdunlap@...radead.org>

thanks.
-- 
~Randy