linux-kernel - Re: [PATCH 5/9] perf tools: Support PERF_SAMPLE_WEIGHT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3429f643-c0a1-320b-035f-24406d0b8f7d@linux.intel.com>
Date:   Wed, 3 Feb 2021 16:19:34 -0500
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     mingo@...nel.org, linux-kernel@...r.kernel.org,
        peterz@...radead.org, eranian@...gle.com, namhyung@...nel.org,
        jolsa@...hat.com, ak@...ux.intel.com, yao.jin@...ux.intel.com,
        maddy@...ux.vnet.ibm.com
Subject: Re: [PATCH 5/9] perf tools: Support PERF_SAMPLE_WEIGHT_STRUCT



On 2/3/2021 3:31 PM, Arnaldo Carvalho de Melo wrote:
>> --- a/tools/perf/util/perf_event_attr_fprintf.c
>> +++ b/tools/perf/util/perf_event_attr_fprintf.c
>> @@ -35,7 +35,7 @@ static void __p_sample_type(char *buf, size_t size, u64 value)
>>   		bit_name(BRANCH_STACK), bit_name(REGS_USER), bit_name(STACK_USER),
>>   		bit_name(IDENTIFIER), bit_name(REGS_INTR), bit_name(DATA_SRC),
>>   		bit_name(WEIGHT), bit_name(PHYS_ADDR), bit_name(AUX),
>> -		bit_name(CGROUP), bit_name(DATA_PAGE_SIZE),
>> +		bit_name(CGROUP), bit_name(DATA_PAGE_SIZE), bit_name(WEIGHT_STRUCT),
> I have CODE_PAGE_SIZE in my perf/core branch, was this somehow removed?
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=perf/core&id=c1de7f3d84ca324c7cda85c3ce27b11741af2124
> 
> I see, you did this patchkit on top of upstream, that has just
> DATA_PAGE_SIZE, while my perf/core branch has CODE_PAGE_SIZE. I'm
> adjusting it, please next time do tooling development on acme/perf/core.

Sorry, I will rebase the patchset on acme/perf/core.

Thanks,
Kan